mirror of
https://github.com/Seldaek/monolog.git
synced 2026-04-26 08:05:53 +03:00
[GH-ISSUE #1302] Confusing [array] usage for a Record model #540
Labels
No labels
Bug
Documentation
Feature
Needs Work
Support
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/monolog#540
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nitso on GitHub (Mar 20, 2019).
Original GitHub issue: https://github.com/Seldaek/monolog/issues/1302
Hi!
Using an array model for a Record (in internals) confuses me when working with monolog.
Adding a record interface will clean up method signatures and internal structure.
What do you think about refactoring? Is it worth a PR?
I suppose that changes must be either backwards compatible or cause a new major version.
@Seldaek commented on GitHub (Jul 2, 2019):
Sorry that it's confusing you but I find it simpler and not necessary to have objects as records..
@stof commented on GitHub (Jul 2, 2019):
and such change cannot be backward compatible (as both processors and handlers deal with the record, and they are both extension points)