[GH-ISSUE #1302] Confusing [array] usage for a Record model #540

Closed
opened 2026-03-04 02:15:49 +03:00 by kerem · 2 comments
Owner

Originally created by @nitso on GitHub (Mar 20, 2019).
Original GitHub issue: https://github.com/Seldaek/monolog/issues/1302

Hi!

Using an array model for a Record (in internals) confuses me when working with monolog.
Adding a record interface will clean up method signatures and internal structure.

What do you think about refactoring? Is it worth a PR?
I suppose that changes must be either backwards compatible or cause a new major version.

Originally created by @nitso on GitHub (Mar 20, 2019). Original GitHub issue: https://github.com/Seldaek/monolog/issues/1302 Hi! Using an array model for a Record (in internals) confuses me when working with monolog. Adding a record interface will clean up method signatures and internal structure. What do you think about refactoring? Is it worth a PR? I suppose that changes must be either backwards compatible or cause a new major version.
kerem closed this issue 2026-03-04 02:15:49 +03:00
Author
Owner

@Seldaek commented on GitHub (Jul 2, 2019):

Sorry that it's confusing you but I find it simpler and not necessary to have objects as records..

<!-- gh-comment-id:507616431 --> @Seldaek commented on GitHub (Jul 2, 2019): Sorry that it's confusing you but I find it simpler and not necessary to have objects as records..
Author
Owner

@stof commented on GitHub (Jul 2, 2019):

and such change cannot be backward compatible (as both processors and handlers deal with the record, and they are both extension points)

<!-- gh-comment-id:507629395 --> @stof commented on GitHub (Jul 2, 2019): and such change cannot be backward compatible (as both processors and handlers deal with the record, and they are both extension points)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/monolog#540
No description provided.