mirror of
https://github.com/Seldaek/monolog.git
synced 2026-04-26 08:05:53 +03:00
[GH-ISSUE #152] New commit 01721704fd causes FireBug to break #49
Labels
No labels
Bug
Documentation
Feature
Needs Work
Support
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/monolog#49
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @InputOutput on GitHub (Jan 22, 2013).
Original GitHub issue: https://github.com/Seldaek/monolog/issues/152
ErrorException: Notice: Undefined property: Symfony\Bridge\Monolog\Handler\FirePHPHandler::$sendHeaders in /vagrant/vendor/symfony/symfony/src/Symfony/Bridge/Monolog/Handler/FirePHPHandler.php line 66
@tristanbes commented on GitHub (Jan 22, 2013):
+1 caused by
d8d5f96760ping @Seldaek It's crashing the whole application
@tristanbes commented on GitHub (Jan 22, 2013):
Thanks ;-)
@Seldaek commented on GitHub (Jan 22, 2013):
OK I added some BC layer, which I think will work. I don't have a symfony 2.2 project at hand so please run composer update and confirm if it worked :)
If it doesn't work, as a workaround you can require monolog in "1.3.1" explicitly for now.
@tristanbes commented on GitHub (Jan 22, 2013):
i'll do this right now.
@tristanbes commented on GitHub (Jan 22, 2013):
@Seldaek PHP Fatal error: Cannot redeclare Monolog\Handler\FirePHPHandler::$sendHeaders in /Volumes/Elao/workspace/6board/vendor/monolog/monolog/src/Monolog/Handler/FirePHPHandler.php on line 59
@Seldaek commented on GitHub (Jan 22, 2013):
I am a moron, please update again :)
@tristanbes commented on GitHub (Jan 22, 2013):
Fixed. ;-) 👍
@Seldaek commented on GitHub (Jan 22, 2013):
OK thanks. If you can please check that it also still disables it properly, like if you view the headers in chrome it shouldn't contain the firephp headers for example. But I think the patch is alright now.
@tristanbes commented on GitHub (Jan 22, 2013):
I can confirm that :
@InputOutput commented on GitHub (Jan 23, 2013):
Fixed the problem on my side too, thanks!
@hasryan commented on GitHub (Jan 24, 2013):
Terribly sorry to see the issues caused by my original commit. We use Monolog in isolation and I was unaware of the impact it could have elsewhere. Apologies for the trouble.
@Seldaek commented on GitHub (Jan 24, 2013):
No worries, I should have been more cautious with removing protected properties too, anyway everyone is back on track. It's part of the risks (and fun?) of using unstable versions :)