[GH-ISSUE #120] Always do count on buffer array not a good idea #40

New issue

Closed

opened 2026-03-04 02:11:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:11:36 +03:00

Owner

Originally created by @omgnull on GitHub (Sep 20, 2012).
Original GitHub issue: https://github.com/Seldaek/monolog/issues/120

This issue for all buffered handlers.

    $this->buffer[] = $record;
    if ($this->bufferSize > 0 && count($this->buffer) > $this->bufferSize) {
        array_shift($this->buffer);
    }

Better its shoud be independent counter and change the name "size" to "limit"

    $this->buffer[] = $record;
    $this->bufferSize++;
    if ($this->bufferLimit > 0 && $this->bufferSize === $this->bufferLimit) {
        array_shift($this->buffer);
        $this->bufferSize--;
    }

Or add option to flush records if buffer is full

Originally created by @omgnull on GitHub (Sep 20, 2012). Original GitHub issue: https://github.com/Seldaek/monolog/issues/120 This issue for all buffered handlers. ``` php $this->buffer[] = $record; if ($this->bufferSize > 0 && count($this->buffer) > $this->bufferSize) { array_shift($this->buffer); } ``` Better its shoud be independent counter and change the name "size" to "limit" ``` php $this->buffer[] = $record; $this->bufferSize++; if ($this->bufferLimit > 0 && $this->bufferSize === $this->bufferLimit) { array_shift($this->buffer); $this->bufferSize--; } ``` Or add option to flush records if buffer is full