mirror of
https://github.com/Seldaek/monolog.git
synced 2026-04-27 08:35:53 +03:00
[GH-ISSUE #920] SlackWebhookHandler can't prevent RuntimeException [proposal] #367
Labels
No labels
Bug
Documentation
Feature
Needs Work
Support
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/monolog#367
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @vrubiella on GitHub (Feb 7, 2017).
Original GitHub issue: https://github.com/Seldaek/monolog/issues/920
If slack sevice is down (or inactivated webhook), slow, or url is malformed, a Fatal RuntimeException raised.
I propose add configure options on the handler to ignore this errors or define timeout requests.
In other case we are "hard-coupling" our service to slack service.
@mintobit commented on GitHub (Feb 24, 2017):
@vrubiella Have you tried WhatFailureGroupHandler?
@Seldaek commented on GitHub (Mar 12, 2017):
We offer the WhatFailureGroupHandler that lets you ignore failures from any handler. It's the recommended way to go because it lets you configure everything without hiding errors, and once you know everything work, if you think the logging is non-essential then you can wrap it with that and make sure a log failure does not bring down the application with it.
@vrubiella commented on GitHub (Oct 4, 2017):
@Seldaek I didn't read you. Thanks!