[GH-ISSUE #835] JsonFormatter::normalize() should pass \Throwable to ::normalizeException() on PHP7 #324

Closed
opened 2026-03-04 02:14:08 +03:00 by kerem · 1 comment
Owner

Originally created by @eimanavicius on GitHub (Aug 27, 2016).
Original GitHub issue: https://github.com/Seldaek/monolog/issues/835

JsonFormatter::normalizeException() handles \Throwable:
https://github.com/Seldaek/monolog/blob/1.x/src/Monolog/Formatter/JsonFormatter.php#L173

but JsonFormatter::normalize() do not passes it to normalizeException():
https://github.com/Seldaek/monolog/blob/1.x/src/Monolog/Formatter/JsonFormatter.php#L155

Originally created by @eimanavicius on GitHub (Aug 27, 2016). Original GitHub issue: https://github.com/Seldaek/monolog/issues/835 JsonFormatter::normalizeException() handles \Throwable: https://github.com/Seldaek/monolog/blob/1.x/src/Monolog/Formatter/JsonFormatter.php#L173 but JsonFormatter::normalize() do not passes it to normalizeException(): https://github.com/Seldaek/monolog/blob/1.x/src/Monolog/Formatter/JsonFormatter.php#L155
kerem closed this issue 2026-03-04 02:14:08 +03:00
Author
Owner

@eimanavicius commented on GitHub (Aug 27, 2016):

same in master:
https://github.com/Seldaek/monolog/blob/master/src/Monolog/Formatter/JsonFormatter.php#L159

<!-- gh-comment-id:242940966 --> @eimanavicius commented on GitHub (Aug 27, 2016): same in master: https://github.com/Seldaek/monolog/blob/master/src/Monolog/Formatter/JsonFormatter.php#L159
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/monolog#324
No description provided.