mirror of
https://github.com/Seldaek/monolog.git
synced 2026-04-26 08:05:53 +03:00
[GH-ISSUE #66] Consider Extracting the Code For Whether Or Not To Activate the FingersCrossedHandler #19
Labels
No labels
Bug
Documentation
Feature
Needs Work
Support
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/monolog#19
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @schmittjoh on GitHub (Mar 19, 2012).
Original GitHub issue: https://github.com/Seldaek/monolog/issues/66
My proposal would be to extract that code to a dedicated strategy class, for example
ActivationStrategyInterface, and provide the current behavior as anErrorLevelActivationStrategy.My use case at the moment is to not activate the FingersCrossedHandler on certain 404 errors.
If you like the idea, I can provide an implementation.
@Seldaek commented on GitHub (Mar 19, 2012):
Read the IRC discussion and yeah I agree, I typically use CRITICAL instead to avoid those bogus 404s, so I would welcome an improvement in that area. If you have time go for it.