[PR #930] [MERGED] Allow to set custom event_id [LEGACY] #1420

Open
opened 2026-03-04 03:12:44 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Seldaek/monolog/pull/930
Author: @tstrijdhorst
Created: 2/21/2017
Status: Merged
Merged: 3/12/2017
Merged by: @Seldaek

Base: 1.xHead: extra_param_event_id


📝 Commits (4)

  • f00ddde +allow to set a custom event_id as an extra parameter instead of letting Raven generate a UUIDv4
  • 193bb25 +CS
  • db2efef +CS
  • d44e01f +verbose array syntax because of PHP 5.3 support

📊 Changes

2 files changed (+4 additions, -2 deletions)

View changed files

📝 src/Monolog/Handler/RavenHandler.php (+1 -1)
📝 tests/Monolog/Handler/RavenHandlerTest.php (+3 -1)

📄 Description

Raven_Client allows for the event_id to be custom if it's in the data. So I made a PR that adds this to the extra parameters. I made the PR for 0.1.x since our company is not yet using PHP7. I also made a PHP7 version since it's rather simple:

https://github.com/Seldaek/monolog/pull/931

This is the code that allows it:
https://github.com/getsentry/sentry-php/blob/master/lib/Raven/Client.php#L785-L787


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Seldaek/monolog/pull/930 **Author:** [@tstrijdhorst](https://github.com/tstrijdhorst) **Created:** 2/21/2017 **Status:** ✅ Merged **Merged:** 3/12/2017 **Merged by:** [@Seldaek](https://github.com/Seldaek) **Base:** `1.x` ← **Head:** `extra_param_event_id` --- ### 📝 Commits (4) - [`f00ddde`](https://github.com/Seldaek/monolog/commit/f00ddde0024bf4096a0c69a55625ff63bfb19622) +allow to set a custom event_id as an extra parameter instead of letting Raven generate a UUIDv4 - [`193bb25`](https://github.com/Seldaek/monolog/commit/193bb2551fbeb546d743c12058a88f4bace974d4) +CS - [`db2efef`](https://github.com/Seldaek/monolog/commit/db2efefb5e6e237148c7623f6ec1e4ad975d4b0b) +CS - [`d44e01f`](https://github.com/Seldaek/monolog/commit/d44e01f53490987a0715042d3c86f82f58b6211a) +verbose array syntax because of PHP 5.3 support ### 📊 Changes **2 files changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Monolog/Handler/RavenHandler.php` (+1 -1) 📝 `tests/Monolog/Handler/RavenHandlerTest.php` (+3 -1) </details> ### 📄 Description Raven_Client allows for the event_id to be custom if it's in the data. So I made a PR that adds this to the extra parameters. I made the PR for 0.1.x since our company is not yet using PHP7. I also made a PHP7 version since it's rather simple: https://github.com/Seldaek/monolog/pull/931 This is the code that allows it: https://github.com/getsentry/sentry-php/blob/master/lib/Raven/Client.php#L785-L787 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/monolog#1420
No description provided.