mirror of
https://github.com/Seldaek/monolog.git
synced 2026-04-25 23:55:56 +03:00
[PR #930] [MERGED] Allow to set custom event_id [LEGACY] #1420
Labels
No labels
Bug
Documentation
Feature
Needs Work
Support
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/monolog#1420
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Seldaek/monolog/pull/930
Author: @tstrijdhorst
Created: 2/21/2017
Status: ✅ Merged
Merged: 3/12/2017
Merged by: @Seldaek
Base:
1.x← Head:extra_param_event_id📝 Commits (4)
f00ddde+allow to set a custom event_id as an extra parameter instead of letting Raven generate a UUIDv4193bb25+CSdb2efef+CSd44e01f+verbose array syntax because of PHP 5.3 support📊 Changes
2 files changed (+4 additions, -2 deletions)
View changed files
📝
src/Monolog/Handler/RavenHandler.php(+1 -1)📝
tests/Monolog/Handler/RavenHandlerTest.php(+3 -1)📄 Description
Raven_Client allows for the event_id to be custom if it's in the data. So I made a PR that adds this to the extra parameters. I made the PR for 0.1.x since our company is not yet using PHP7. I also made a PHP7 version since it's rather simple:
https://github.com/Seldaek/monolog/pull/931
This is the code that allows it:
https://github.com/getsentry/sentry-php/blob/master/lib/Raven/Client.php#L785-L787
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.