[PR #926] [MERGED] Improves code coverage #1417

New issue

Open

opened 2026-03-04 03:12:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 03:12:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Seldaek/monolog/pull/926
Author: @nawarian
Created: 2/17/2017
Status: ✅ Merged
Merged: 3/12/2017
Merged by: @Seldaek

Base: master ← Head: improve-code-coverage

📝 Commits (9)

9f07f4c 100% coverage on ErrorHandler::codeToString
c7169a5 100% coverage on ErrorHandler::registerFatalHandler
3c23663 fix typo
5be4fe5 covers ErrorHandler::register() and left conditions on purpose
fc5ae0d 100% coverage on ErrorHandler::registerErrorHandler()
7bccee0 100% coverage on ErrorHandler::registerExceptionHandler()
1cc7e00 Checks for possible interface breaking changes
c46a648 100% coverage on ErrorHandler::codeToString
c049d36 Merge branch 'improve-code-coverage' of https://github.com/nawarian/monolog into improve-code-coverage

📊 Changes

1 file changed (+81 additions, -2 deletions)

View changed files

📝 tests/Monolog/ErrorHandlerTest.php (+81 -2)

📄 Description

This will improve code coverage on Monolog\ErrorHandler class.

I left ErrorHandler::register not fully covered on purpose, since I got no easy way to test handlers methods.

Hope this helps. :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Seldaek/monolog/pull/926 **Author:** [@nawarian](https://github.com/nawarian) **Created:** 2/17/2017 **Status:** ✅ Merged **Merged:** 3/12/2017 **Merged by:** [@Seldaek](https://github.com/Seldaek) **Base:** `master` ← **Head:** `improve-code-coverage` --- ### 📝 Commits (9) - [`9f07f4c`](https://github.com/Seldaek/monolog/commit/9f07f4c5fe0d8adfeecaaadbc68e5854fa55a418) 100% coverage on ErrorHandler::codeToString - [`c7169a5`](https://github.com/Seldaek/monolog/commit/c7169a5fd30656428bdf093ffdb7a7434ae92d1f) 100% coverage on ErrorHandler::registerFatalHandler - [`3c23663`](https://github.com/Seldaek/monolog/commit/3c23663b912f1c78722b68716109f09220ad9a70) fix typo - [`5be4fe5`](https://github.com/Seldaek/monolog/commit/5be4fe52f710586c29c30cadf0770fb16e4dfd4f) covers ErrorHandler::register() and left conditions on purpose - [`fc5ae0d`](https://github.com/Seldaek/monolog/commit/fc5ae0d51242966f0af59a6b9f0ecab548a8af3a) 100% coverage on ErrorHandler::registerErrorHandler() - [`7bccee0`](https://github.com/Seldaek/monolog/commit/7bccee09819fd378e8689d0f25d6a92058be9ba1) 100% coverage on ErrorHandler::registerExceptionHandler() - [`1cc7e00`](https://github.com/Seldaek/monolog/commit/1cc7e0063cea25869fc4c84b0987e32b32538727) Checks for possible interface breaking changes - [`c46a648`](https://github.com/Seldaek/monolog/commit/c46a64825e7db76249b40f24e3d0ab1faf419a36) 100% coverage on ErrorHandler::codeToString - [`c049d36`](https://github.com/Seldaek/monolog/commit/c049d36ee0d104eb0ad9e12866d0f2a986c597f7) Merge branch 'improve-code-coverage' of https://github.com/nawarian/monolog into improve-code-coverage ### 📊 Changes **1 file changed** (+81 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `tests/Monolog/ErrorHandlerTest.php` (+81 -2) </details> ### 📄 Description This will improve code coverage on `Monolog\ErrorHandler` class. I left `ErrorHandler::register` not fully covered on purpose, since I got no easy way to test handlers methods. Hope this helps. :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>