[PR #886] [CLOSED] Public generic methods in TestHandler #1399

New issue

Closed

opened 2026-03-04 03:11:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 03:11:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Seldaek/monolog/pull/886
Author: @julienfalque
Created: 11/15/2016
Status: ❌ Closed

Base: master ← Head: test-handler-generic-methods

📝 Commits (1)

575940f Make protected generic methods public

📊 Changes

2 files changed (+7 additions, -3 deletions)

View changed files

📝 src/Monolog/Handler/TestHandler.php (+3 -3)
📝 tests/Monolog/Handler/TestHandlerTest.php (+4 -0)

📄 Description

Makes TestHandler::hasRecordRecords() and TestHandler::hasRecord() public so they can be used in tests directly just like the other generic methods. Also renames hasRecordRecords to hasRecords because hasRecordRecords is kinda weird.
Not sure the protected to public change would be a BC break for 1.x. If not, I can set the hasRecordRecords method back with a deprecation message. WDYT?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Seldaek/monolog/pull/886 **Author:** [@julienfalque](https://github.com/julienfalque) **Created:** 11/15/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `test-handler-generic-methods` --- ### 📝 Commits (1) - [`575940f`](https://github.com/Seldaek/monolog/commit/575940f02930f166b99882590ea0c431c9e84214) Make protected generic methods public ### 📊 Changes **2 files changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/Monolog/Handler/TestHandler.php` (+3 -3) 📝 `tests/Monolog/Handler/TestHandlerTest.php` (+4 -0) </details> ### 📄 Description Makes `TestHandler::hasRecordRecords()` and `TestHandler::hasRecord()` public so they can be used in tests directly just like the other generic methods. Also renames `hasRecordRecords` to `hasRecords` because _hasRecordRecords_ is kinda weird. Not sure the `protected` to `public` change would be a BC break for 1.x. If not, I can set the `hasRecordRecords` method back with a deprecation message. WDYT? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>