[PR #793] [MERGED] Datetime changes #1358

New issue

Closed

opened 2026-03-04 03:10:37 +03:00 by kerem · 0 comments

kerem commented 2026-03-04 03:10:37 +03:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/Seldaek/monolog/pull/793
Author: @Seldaek
Created: 5/20/2016
Status: ✅ Merged
Merged: 5/26/2016
Merged by: @Seldaek

Base: master ← Head: datetime-changes

---

📝 Commits (2)

• e27225d Switch to DateTimeImmutable everywhere
• 912d813 Add our own DateTime implementation to provide nicer JSON output, fixes #736

📊 Changes

24 files changed (+140 additions, -83 deletions)

View changed files

➕ src/Monolog/DateTimeImmutable.php (+48 -0)
📝 src/Monolog/Formatter/LogglyFormatter.php (+1 -1)
📝 src/Monolog/Formatter/NormalizerFormatter.php (+1 -1)
📝 src/Monolog/Formatter/WildfireFormatter.php (+1 -1)
📝 src/Monolog/Handler/ChromePHPHandler.php (+2 -2)
📝 src/Monolog/Handler/RotatingFileHandler.php (+2 -2)
📝 src/Monolog/Logger.php (+14 -6)
📝 src/Monolog/Test/TestCase.php (+2 -1)
📝 tests/Monolog/Formatter/ChromePHPFormatterTest.php (+5 -5)
📝 tests/Monolog/Formatter/ElasticaFormatterTest.php (+1 -1)
📝 tests/Monolog/Formatter/FluentdFormatterTest.php (+2 -2)
📝 tests/Monolog/Formatter/GelfMessageFormatterTest.php (+6 -6)
📝 tests/Monolog/Formatter/JsonFormatterTest.php (+5 -5)
📝 tests/Monolog/Formatter/LineFormatterTest.php (+11 -11)
📝 tests/Monolog/Formatter/LogglyFormatterTest.php (+1 -1)
📝 tests/Monolog/Formatter/LogstashFormatterTest.php (+6 -6)
📝 tests/Monolog/Formatter/MongoDBFormatterTest.php (+7 -7)
📝 tests/Monolog/Formatter/NormalizerFormatterTest.php (+3 -3)
📝 tests/Monolog/Formatter/ScalarFormatterTest.php (+1 -1)
📝 tests/Monolog/Formatter/WildfireFormatterTest.php (+5 -5)

...and 4 more files

📄 Description

Fixes #736

• Uses DateTimeImmutable for everything
• Added our own class extending it that means datetimes get serialized in json as "Y-m-d\TH:i:s.uP" or "Y-m-d\TH:i:sP" depending if microsecond precision is enabled.

Feedback welcome :)

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Seldaek/monolog/pull/793 **Author:** [@Seldaek](https://github.com/Seldaek) **Created:** 5/20/2016 **Status:** ✅ Merged **Merged:** 5/26/2016 **Merged by:** [@Seldaek](https://github.com/Seldaek) **Base:** `master` ← **Head:** `datetime-changes` --- ### 📝 Commits (2) - [`e27225d`](https://github.com/Seldaek/monolog/commit/e27225dc402bfdcfabc336832110256f9b6de5ab) Switch to DateTimeImmutable everywhere - [`912d813`](https://github.com/Seldaek/monolog/commit/912d813c7345ffe97ddcf1469bd3223fdf27d538) Add our own DateTime implementation to provide nicer JSON output, fixes #736 ### 📊 Changes **24 files changed** (+140 additions, -83 deletions) <details> <summary>View changed files</summary> ➕ `src/Monolog/DateTimeImmutable.php` (+48 -0) 📝 `src/Monolog/Formatter/LogglyFormatter.php` (+1 -1) 📝 `src/Monolog/Formatter/NormalizerFormatter.php` (+1 -1) 📝 `src/Monolog/Formatter/WildfireFormatter.php` (+1 -1) 📝 `src/Monolog/Handler/ChromePHPHandler.php` (+2 -2) 📝 `src/Monolog/Handler/RotatingFileHandler.php` (+2 -2) 📝 `src/Monolog/Logger.php` (+14 -6) 📝 `src/Monolog/Test/TestCase.php` (+2 -1) 📝 `tests/Monolog/Formatter/ChromePHPFormatterTest.php` (+5 -5) 📝 `tests/Monolog/Formatter/ElasticaFormatterTest.php` (+1 -1) 📝 `tests/Monolog/Formatter/FluentdFormatterTest.php` (+2 -2) 📝 `tests/Monolog/Formatter/GelfMessageFormatterTest.php` (+6 -6) 📝 `tests/Monolog/Formatter/JsonFormatterTest.php` (+5 -5) 📝 `tests/Monolog/Formatter/LineFormatterTest.php` (+11 -11) 📝 `tests/Monolog/Formatter/LogglyFormatterTest.php` (+1 -1) 📝 `tests/Monolog/Formatter/LogstashFormatterTest.php` (+6 -6) 📝 `tests/Monolog/Formatter/MongoDBFormatterTest.php` (+7 -7) 📝 `tests/Monolog/Formatter/NormalizerFormatterTest.php` (+3 -3) 📝 `tests/Monolog/Formatter/ScalarFormatterTest.php` (+1 -1) 📝 `tests/Monolog/Formatter/WildfireFormatterTest.php` (+5 -5) _...and 4 more files_ </details> ### 📄 Description Fixes #736 - Uses DateTimeImmutable for everything - Added our own class extending it that means datetimes get serialized in json as `"Y-m-d\TH:i:s.uP"` or `"Y-m-d\TH:i:sP"` depending if microsecond precision is enabled. Feedback welcome :) --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

kerem 2026-03-04 03:10:37 +03:00

• closed this issue
• added the
  pull-request
  label

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

esfix

2.x

1.x

3.10.0

2.11.0

3.9.0

3.8.1

3.8.0

2.10.0

3.7.0

3.6.0

2.9.3

3.5.0

2.9.2

3.4.0

3.3.1

2.9.1

3.3.0

2.9.0

3.2.0

2.8.0

3.1.0

2.7.0

1.27.1

3.0.0

2.6.0

3.0.0-RC1

2.5.0

2.4.0

1.27.0

2.3.5

2.3.4

2.3.3

2.3.2

2.3.1

2.3.0

1.26.1

2.2.0

1.26.0

2.1.1

1.25.5

2.1.0

1.25.4

2.0.2

1.25.3

2.0.1

1.25.2

1.25.1

1.25.0

2.0.0

2.0.0-beta2

2.0.0-beta1

1.24.0

1.23.0

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.2

1.18.1

1.18.0

1.17.2

1.17.1

1.17.0

1.16.0

1.15.0

1.14.0

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.0

1.5.0

1.4.1

1.4.0

1.3.1

1.3.0

1.2.1

1.2.0

1.1.0

1.0.2

1.0.1

1.0.0

1.0.0-RC1

Labels

Clear labels   

Bug

  

Documentation

  

Feature

  

Needs Work

  

Support

  

pull-request

Mirrored from GitHub Pull Request

No labels

Bug

Documentation

Feature

Needs Work

Support

pull-request

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/monolog#1358

No description provided.