[PR #707] [MERGED] Removed unnecessary php version checks after php dependency bump to 7.0 #1308

Closed
opened 2026-03-04 03:09:15 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Seldaek/monolog/pull/707
Author: @acrobat
Created: 12/20/2015
Status: Merged
Merged: 12/22/2015
Merged by: @Seldaek

Base: masterHead: version_compare_fixes


📝 Commits (1)

  • 8ceda1b Removed unnecessary php version checks after php dependency bump to 7.0

📊 Changes

6 files changed (+8 additions, -54 deletions)

View changed files

📝 src/Monolog/Formatter/HtmlFormatter.php (+1 -4)
📝 src/Monolog/Formatter/LineFormatter.php (+1 -5)
📝 src/Monolog/Formatter/NormalizerFormatter.php (+1 -5)
📝 tests/Monolog/Formatter/LogstashFormatterTest.php (+1 -11)
📝 tests/Monolog/Formatter/NormalizerFormatterTest.php (+3 -24)
📝 tests/Monolog/Formatter/ScalarFormatterTest.php (+1 -5)

📄 Description

Fixed todo from #197

Check all PHP_VERSION and version_compare checks for relevance


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Seldaek/monolog/pull/707 **Author:** [@acrobat](https://github.com/acrobat) **Created:** 12/20/2015 **Status:** ✅ Merged **Merged:** 12/22/2015 **Merged by:** [@Seldaek](https://github.com/Seldaek) **Base:** `master` ← **Head:** `version_compare_fixes` --- ### 📝 Commits (1) - [`8ceda1b`](https://github.com/Seldaek/monolog/commit/8ceda1b62e94141a32382a314a2f83d9bf26c2cf) Removed unnecessary php version checks after php dependency bump to 7.0 ### 📊 Changes **6 files changed** (+8 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `src/Monolog/Formatter/HtmlFormatter.php` (+1 -4) 📝 `src/Monolog/Formatter/LineFormatter.php` (+1 -5) 📝 `src/Monolog/Formatter/NormalizerFormatter.php` (+1 -5) 📝 `tests/Monolog/Formatter/LogstashFormatterTest.php` (+1 -11) 📝 `tests/Monolog/Formatter/NormalizerFormatterTest.php` (+3 -24) 📝 `tests/Monolog/Formatter/ScalarFormatterTest.php` (+1 -5) </details> ### 📄 Description Fixed todo from #197 > Check all PHP_VERSION and version_compare checks for relevance --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 03:09:15 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/monolog#1308
No description provided.