[PR #498] [MERGED] Restore ability to continue using mlehner/gelf-php in test #1187

New issue

Closed

opened 2026-03-04 03:06:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 03:06:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Seldaek/monolog/pull/498
Author: @johnkary
Created: 1/20/2015
Status: ✅ Merged
Merged: 1/20/2015
Merged by: @Seldaek

Base: master ← Head: fixGelfTests

📝 Commits (1)

6c18364 Restore ability to continue using mlehner/gelf-php in test

📊 Changes

2 files changed (+27 additions, -0 deletions)

View changed files

📝 tests/Monolog/Handler/GelfHandlerLegacyTest.php (+2 -0)
➕ tests/Monolog/Handler/GelfMocks.php (+25 -0)

📄 Description

Was previously broken by a coding standard commit 392ef35fd4 that removed some mock files necessary to execute the tests when graylog2/gelf-php is deleted and mlehner/gelf-php is installed instead. This is hidden from normal test suite runs because the tests are skipped when mlehner/gelf-php is not installed.

You can check that this wasn't working against the master branch by doing the following:

$ composer require --dev mlehner/gelf-php
$ rm -rfd vendor/graylog2
$ vendor/bin/phpunit

I was working on another contribution and wondered why so many tests were skipped in the Monolog test suite. I found this issue after digging into a few of the skips.

I'm not 100% sure on the history of the mlehner/gelf-php and graylog2/gelf-php packages, but the tests showed they should support both packages. So maybe we either accept this PR, or remove support for mlehner/gelf-php?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Seldaek/monolog/pull/498 **Author:** [@johnkary](https://github.com/johnkary) **Created:** 1/20/2015 **Status:** ✅ Merged **Merged:** 1/20/2015 **Merged by:** [@Seldaek](https://github.com/Seldaek) **Base:** `master` ← **Head:** `fixGelfTests` --- ### 📝 Commits (1) - [`6c18364`](https://github.com/Seldaek/monolog/commit/6c1836467cdd8cca83d3ad54504709e232328774) Restore ability to continue using mlehner/gelf-php in test ### 📊 Changes **2 files changed** (+27 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `tests/Monolog/Handler/GelfHandlerLegacyTest.php` (+2 -0) ➕ `tests/Monolog/Handler/GelfMocks.php` (+25 -0) </details> ### 📄 Description Was previously broken by a coding standard commit 392ef35fd470638e08d0160d6b1cbab63cb23174 that removed some mock files necessary to execute the tests when graylog2/gelf-php is deleted and mlehner/gelf-php is installed instead. This is hidden from normal test suite runs because the tests are skipped when mlehner/gelf-php is not installed. You can check that this wasn't working against the master branch by doing the following: ``` $ composer require --dev mlehner/gelf-php $ rm -rfd vendor/graylog2 $ vendor/bin/phpunit ``` I was working on another contribution and wondered why so many tests were skipped in the Monolog test suite. I found this issue after digging into a few of the skips. I'm not 100% sure on the history of the mlehner/gelf-php and graylog2/gelf-php packages, but the tests showed they should support both packages. So maybe we either accept this PR, or remove support for mlehner/gelf-php? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>