[PR #290] [MERGED] Add name length check to the HipChatHandler #1057

New issue

Closed

opened 2026-03-04 03:04:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 03:04:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Seldaek/monolog/pull/290
Author: @levacic
Created: 12/24/2013
Status: ✅ Merged
Merged: 12/25/2013
Merged by: @Seldaek

Base: master ← Head: hipchat-name-length

📝 Commits (1)

67a9087 Add name length check to the HipChatHandler

📊 Changes

2 files changed (+39 additions, -0 deletions)

View changed files

📝 src/Monolog/Handler/HipChatHandler.php (+31 -0)
📝 tests/Monolog/Handler/HipChatHandlerTest.php (+8 -0)

📄 Description

As explained in its docblock, the validation function will fall back to
a simple strlen check if mb_strlen is not available. However, that very
specific case is not one that was deemed important to support, as anyone
using UTF-8 in their code, without having mbstring available will
probably have bigger problems to worry about.

Fixes #289

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Seldaek/monolog/pull/290 **Author:** [@levacic](https://github.com/levacic) **Created:** 12/24/2013 **Status:** ✅ Merged **Merged:** 12/25/2013 **Merged by:** [@Seldaek](https://github.com/Seldaek) **Base:** `master` ← **Head:** `hipchat-name-length` --- ### 📝 Commits (1) - [`67a9087`](https://github.com/Seldaek/monolog/commit/67a908796b4f1aa48e2deca96174c8cd04c8776f) Add name length check to the HipChatHandler ### 📊 Changes **2 files changed** (+39 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Monolog/Handler/HipChatHandler.php` (+31 -0) 📝 `tests/Monolog/Handler/HipChatHandlerTest.php` (+8 -0) </details> ### 📄 Description As explained in its docblock, the validation function will fall back to a simple strlen check if mb_strlen is not available. However, that very specific case is not one that was deemed important to support, as anyone using UTF-8 in their code, without having mbstring available will probably have bigger problems to worry about. Fixes #289 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>