mirror of
https://github.com/Seldaek/monolog.git
synced 2026-04-26 16:15:49 +03:00
[GH-ISSUE #312] HipChatHandler doesn't implement handleBatch() #103
Labels
No labels
Bug
Documentation
Feature
Needs Work
Support
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/monolog#103
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @leevigraham on GitHub (Jan 23, 2014).
Original GitHub issue: https://github.com/Seldaek/monolog/issues/312
Could this be implemented?
HipChat Api supports max 10k characters per post which could be an issue. To solve this we could concatenate multiple messages checking if the result would be more or less than 10k characters.
My other concern is how to handle a single message over 10k characters. This probably hasn't been an issue given a single log message is generally quite short.
@stof commented on GitHub (Jan 23, 2014):
handleBatchis implemented: https://github.com/Seldaek/monolog/blob/master/src/Monolog/Handler/HipChatHandler.php#L165It does not seem to handle the max length though
@leevigraham commented on GitHub (Jan 23, 2014):
My bad. I just updated the bundle and obviously didn't check the actual Seldaek/monolog repo.
@leevigraham commented on GitHub (Jan 23, 2014):
Added limit to handleBatch calls: PR #313