[GH-ISSUE #312] HipChatHandler doesn't implement handleBatch() #103

Closed
opened 2026-03-04 02:12:14 +03:00 by kerem · 3 comments
Owner

Originally created by @leevigraham on GitHub (Jan 23, 2014).
Original GitHub issue: https://github.com/Seldaek/monolog/issues/312

Could this be implemented?

HipChat Api supports max 10k characters per post which could be an issue. To solve this we could concatenate multiple messages checking if the result would be more or less than 10k characters.

My other concern is how to handle a single message over 10k characters. This probably hasn't been an issue given a single log message is generally quite short.

Originally created by @leevigraham on GitHub (Jan 23, 2014). Original GitHub issue: https://github.com/Seldaek/monolog/issues/312 Could this be implemented? HipChat Api supports max 10k characters per post which could be an issue. To solve this we could concatenate multiple messages checking if the result would be more or less than 10k characters. My other concern is how to handle a single message over 10k characters. This probably hasn't been an issue given a single log message is generally quite short.
kerem closed this issue 2026-03-04 02:12:14 +03:00
Author
Owner

@stof commented on GitHub (Jan 23, 2014):

handleBatch is implemented: https://github.com/Seldaek/monolog/blob/master/src/Monolog/Handler/HipChatHandler.php#L165

It does not seem to handle the max length though

<!-- gh-comment-id:33118719 --> @stof commented on GitHub (Jan 23, 2014): `handleBatch` is implemented: https://github.com/Seldaek/monolog/blob/master/src/Monolog/Handler/HipChatHandler.php#L165 It does not seem to handle the max length though
Author
Owner

@leevigraham commented on GitHub (Jan 23, 2014):

My bad. I just updated the bundle and obviously didn't check the actual Seldaek/monolog repo.

<!-- gh-comment-id:33119240 --> @leevigraham commented on GitHub (Jan 23, 2014): My bad. I just updated the bundle and obviously didn't check the actual Seldaek/monolog repo.
Author
Owner

@leevigraham commented on GitHub (Jan 23, 2014):

Added limit to handleBatch calls: PR #313

<!-- gh-comment-id:33123858 --> @leevigraham commented on GitHub (Jan 23, 2014): Added limit to handleBatch calls: PR #313
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/monolog#103
No description provided.