[PR #52] [MERGED] Upgrade Django (Django-1.10 no longer supported) #67

New issue

Closed

opened 2026-02-27 10:25:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 10:25:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa-postfix-autoreply/pull/52
Author: @ghost
Created: 12/19/2017
Status: ✅ Merged
Merged: 12/21/2017
Merged by: @tonioo

Base: master ← Head: upgrade-django

📝 Commits (4)

7e23b86 standardise travis.yml across modoboa extensions
0b9bada updates for django 1.11 support
7e8fd30 update test_project files
a8929c1 smart_str should be smart_text, otherwise tests break on python 2

📊 Changes

10 files changed (+181 additions, -50 deletions)

View changed files

📝 .travis.yml (+33 -16)
📝 modoboa_postfix_autoreply/management/commands/autoreply.py (+2 -2)
📝 modoboa_postfix_autoreply/migrations/0001_initial.py (+2 -2)
📝 modoboa_postfix_autoreply/models.py (+2 -2)
📝 modoboa_postfix_autoreply/tests.py (+3 -1)
➕ test-requirements.txt (+2 -0)
📝 test_project/manage.py (+18 -3)
📝 test_project/test_project/settings.py (+110 -21)
📝 test_project/test_project/urls.py (+3 -1)
📝 test_project/test_project/wsgi.py (+6 -2)

📄 Description

Django 1.10 is now no longer supported, this PR upgrades modoboa to Django 1.11 (the last version of Django to support Python 2). This depends on modoboa/modoboa#1333

I've split this into several patches to make it easier to follow:

7e23b86: make all the travis.yml settings the same across modoboa projects.
0b9bada: updates for django 1.11 support
- on_delete will become a required parameter for ForeignKey() set it to the current default CASCADE
- reverse and reverse_lazy have moved to django.urls
- MIDDLEWARE_CLASSES is replaced by MIDDLEWARE
7e8fd30: updated test_project, synced with a fresh deployment using Django 1.11.8 and updated settings.py so the tests environment matches a fresh deployment.
a8929c1: smart_str should be smart_text, otherwise tests break on python 2

As this depends on modoboa/modoboa#1333 tests on travis will fail until it's merged, I've created a special branch (with altered travis.yml) to prove the tests work upgrade-django-TESTS

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa-postfix-autoreply/pull/52 **Author:** [@ghost](https://github.com/ghost) **Created:** 12/19/2017 **Status:** ✅ Merged **Merged:** 12/21/2017 **Merged by:** [@tonioo](https://github.com/tonioo) **Base:** `master` ← **Head:** `upgrade-django` --- ### 📝 Commits (4) - [`7e23b86`](https://github.com/modoboa/modoboa-postfix-autoreply/commit/7e23b86296aa35d689d5c65de34296e88b0f9dbe) standardise travis.yml across modoboa extensions - [`0b9bada`](https://github.com/modoboa/modoboa-postfix-autoreply/commit/0b9bada3baa7e7eb6fb184ff8d0fb856c5de2a0c) updates for django 1.11 support - [`7e8fd30`](https://github.com/modoboa/modoboa-postfix-autoreply/commit/7e8fd309301132c2faf95140d10660a1fb8f37bc) update test_project files - [`a8929c1`](https://github.com/modoboa/modoboa-postfix-autoreply/commit/a8929c1c8f1f6f0c8d1a8730d6c43e0df0052761) smart_str should be smart_text, otherwise tests break on python 2 ### 📊 Changes **10 files changed** (+181 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+33 -16) 📝 `modoboa_postfix_autoreply/management/commands/autoreply.py` (+2 -2) 📝 `modoboa_postfix_autoreply/migrations/0001_initial.py` (+2 -2) 📝 `modoboa_postfix_autoreply/models.py` (+2 -2) 📝 `modoboa_postfix_autoreply/tests.py` (+3 -1) ➕ `test-requirements.txt` (+2 -0) 📝 `test_project/manage.py` (+18 -3) 📝 `test_project/test_project/settings.py` (+110 -21) 📝 `test_project/test_project/urls.py` (+3 -1) 📝 `test_project/test_project/wsgi.py` (+6 -2) </details> ### 📄 Description Django 1.10 is now [no longer supported](https://www.djangoproject.com/download/#supported-versions), this PR upgrades modoboa to Django 1.11 (the last version of Django to support Python 2). This depends on modoboa/modoboa#1333 I've split this into several patches to make it easier to follow: - 7e23b86: make all the travis.yml settings the same across modoboa projects. - 0b9bada: updates for django 1.11 support - on_delete will become a required parameter for ForeignKey() set it to the current default CASCADE - reverse and reverse_lazy have moved to django.urls - MIDDLEWARE_CLASSES is replaced by MIDDLEWARE - 7e8fd30: updated test_project, synced with a fresh deployment using Django 1.11.8 and updated settings.py so the tests environment matches a fresh deployment. - a8929c1: smart_str should be smart_text, otherwise tests break on python 2 --- As this depends on modoboa/modoboa#1333 tests on travis will fail until it's merged, I've created a special branch (with altered travis.yml) to prove the tests work [upgrade-django-TESTS](https://travis-ci.org/fyfe/modoboa-postfix-autoreply/builds/318276558) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>