starred/modoboa-modoboa
1
0
Fork 0
mirror of https://github.com/modoboa/modoboa.git synced 2026-04-25 17:06:01 +03:00
Code Issues 60 Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #818] Import of aliases broken #732

New issue
Closed
opened 2026-02-27 11:13:16 +03:00 by kerem · 9 comments
kerem commented 2026-02-27 11:13:16 +03:00
Owner
Copy link

Originally created by @ddt-consult on GitHub (Dec 17, 2015).
Original GitHub issue: https://github.com/modoboa/modoboa/issues/818

The import of aliases into modoboa 1.4.2 is broken.
If I try to import one domain with one account and one alias pointing to this account into a fresh installation of modoboa (see CSV files below), the import of the identities fails with "Local recipient not found".
AFAIKT in Alias.set_recipients() modoboa checks whether the target for an alias already exists in the DB. If that's not the case, it checks whether the target is itlself another alias. If that's not the case either, it raises an exception instead of creating the target.
Just for testing I commented lines 133-139 in alias.py, i. e.

                    # if rcpt is None:
                    #     raise NotFound(
                    #         _("Local recipient {}@{} not found")
                    #         .format(local_part, domname)
                    #     )
                    # if rcpt.address == self.address:
                    #     raise Conflict

and the import of my identities file succeeded.

domains.csv:
domain;ddt-consult.de;100000;True

identities.csv:
account;admin@ddt-consult.de;{SHA512-CRYPT}$6$rounds=70000$yOfLHTrqigEMkPlW$.6Oq0b1bmcrfk8OcuDNzZYbOEVVgkcmrnPH3Mmqwyg6qlBjxVbRX7fGwxWUqYsimYxnGABXME4Ba8xt.1KaTK/;;;True;DomainAdmins;admin@ddt-consult.de;100000;ddt-consult.de alias;abuse@ddt-consult.de;True;admin@ddt-consult.de

Originally created by @ddt-consult on GitHub (Dec 17, 2015). Original GitHub issue: https://github.com/modoboa/modoboa/issues/818 The import of aliases into modoboa 1.4.2 is broken. If I try to import one domain with one account and one alias pointing to this account into a fresh installation of modoboa (see CSV files below), the import of the identities fails with "Local recipient not found". AFAIKT in Alias.set_recipients() modoboa checks whether the target for an alias already exists in the DB. If that's not the case, it checks whether the target is itlself another alias. If that's not the case either, it raises an exception instead of creating the target. Just for testing I commented lines 133-139 in alias.py, i. e. ``` python # if rcpt is None: # raise NotFound( # _("Local recipient {}@{} not found") # .format(local_part, domname) # ) # if rcpt.address == self.address: # raise Conflict ``` and the import of my identities file succeeded. domains.csv: `domain;ddt-consult.de;100000;True` identities.csv: `account;admin@ddt-consult.de;{SHA512-CRYPT}$6$rounds=70000$yOfLHTrqigEMkPlW$.6Oq0b1bmcrfk8OcuDNzZYbOEVVgkcmrnPH3Mmqwyg6qlBjxVbRX7fGwxWUqYsimYxnGABXME4Ba8xt.1KaTK/;;;True;DomainAdmins;admin@ddt-consult.de;100000;ddt-consult.de alias;abuse@ddt-consult.de;True;admin@ddt-consult.de`
kerem 2026-02-27 11:13:16 +03:00
kerem commented 2026-02-27 11:13:17 +03:00
Author
Owner
Copy link

@tonioo commented on GitHub (Jan 5, 2016):

Hi,
I can't reproduce your issue with 1.4.2. Are you importing from the CLI or from the interface ?

<!-- gh-comment-id:168922015 --> @tonioo commented on GitHub (Jan 5, 2016): Hi, I can't reproduce your issue with 1.4.2. Are you importing from the CLI or from the interface ?
kerem commented 2026-02-27 11:13:17 +03:00
Author
Owner
Copy link

@ddt-consult commented on GitHub (Jan 12, 2016):

From the command line.

If you just copied the identities.csv above from this webpage, the linefeed between the account and the alias line may get eaten. Then you would have just one line in the CSV and only the account would get created but not the alias (which triggers the error).

BTW: that's the traceback I get when I try to import this identities.csv:

Traceback (most recent call last):
  File "manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 354, in execute_from_command_line
    utility.execute()
  File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 346, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/django/core/management/base.py", line 394, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/django/core/management/base.py", line 445, in execute
    output = self.handle(*args, **options)
  File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/modoboa/admin/management/commands/import_identities.py", line 34, in handle
    import_csv(filename, kwargs)
  File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/modoboa/admin/management/commands/_import.py", line 43, in import_csv
    fct(superadmin, row, options)
  File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/modoboa/admin/lib.py", line 147, in import_alias
    _import_alias(user, row, expected_elements=4)
  File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/modoboa/admin/lib.py", line 143, in _import_alias
    alias.from_csv(user, row, **kwargs)
  File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/modoboa/admin/models/alias.py", line 177, in from_csv
    self.set_recipients([raddress.strip() for raddress in row[3:]])
  File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/modoboa/admin/models/alias.py", line 134, in set_recipients
    .format(local_part, domname)
modoboa.lib.exceptions.NotFound: Local recipient admin@ddt-consult.de not found
<!-- gh-comment-id:170876387 --> @ddt-consult commented on GitHub (Jan 12, 2016): From the command line. If you just copied the identities.csv above from this webpage, the linefeed between the account and the alias line may get eaten. Then you would have just one line in the CSV and only the account would get created but not the alias (which triggers the error). BTW: that's the traceback I get when I try to import this identities.csv: ``` Traceback (most recent call last): File "manage.py", line 10, in <module> execute_from_command_line(sys.argv) File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 354, in execute_from_command_line utility.execute() File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 346, in execute self.fetch_command(subcommand).run_from_argv(self.argv) File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/django/core/management/base.py", line 394, in run_from_argv self.execute(*args, **cmd_options) File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/django/core/management/base.py", line 445, in execute output = self.handle(*args, **options) File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/modoboa/admin/management/commands/import_identities.py", line 34, in handle import_csv(filename, kwargs) File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/modoboa/admin/management/commands/_import.py", line 43, in import_csv fct(superadmin, row, options) File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/modoboa/admin/lib.py", line 147, in import_alias _import_alias(user, row, expected_elements=4) File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/modoboa/admin/lib.py", line 143, in _import_alias alias.from_csv(user, row, **kwargs) File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/modoboa/admin/models/alias.py", line 177, in from_csv self.set_recipients([raddress.strip() for raddress in row[3:]]) File "/usr/local/share/modoboa-1.4.2/venv/local/lib/python2.7/site-packages/modoboa/admin/models/alias.py", line 134, in set_recipients .format(local_part, domname) modoboa.lib.exceptions.NotFound: Local recipient admin@ddt-consult.de not found ```
kerem commented 2026-02-27 11:13:17 +03:00
Author
Owner
Copy link

@tonioo commented on GitHub (Jan 18, 2016):

I still can't reproduce it. Which database do you use ? Have you made modifications to your settings file ?

<!-- gh-comment-id:172454976 --> @tonioo commented on GitHub (Jan 18, 2016): I still can't reproduce it. Which database do you use ? Have you made modifications to your settings file ?
kerem commented 2026-02-27 11:13:17 +03:00
Author
Owner
Copy link

@ddt-consult commented on GitHub (Jan 18, 2016):

DB: MySQL.
Of course I have made modifications to settings.py: ALLOWED_HOSTS, LANGUAGE_CODE, ...

<!-- gh-comment-id:172456559 --> @ddt-consult commented on GitHub (Jan 18, 2016): DB: MySQL. Of course I have made modifications to settings.py: ALLOWED_HOSTS, LANGUAGE_CODE, ...
kerem commented 2026-02-27 11:13:17 +03:00
Author
Owner
Copy link

@tonioo commented on GitHub (Jan 18, 2016):

Would it be easy for you to check the behaviour using a postgresql database ?

<!-- gh-comment-id:172484138 --> @tonioo commented on GitHub (Jan 18, 2016): Would it be easy for you to check the behaviour using a postgresql database ?
kerem commented 2026-02-27 11:13:17 +03:00
Author
Owner
Copy link

@tonioo commented on GitHub (Jan 27, 2016):

@ddt-consult ping

<!-- gh-comment-id:175685974 --> @tonioo commented on GitHub (Jan 27, 2016): @ddt-consult ping
kerem commented 2026-02-27 11:13:17 +03:00
Author
Owner
Copy link

@dirtyhillbilly commented on GitHub (Oct 3, 2020):

I have the same problem. The misleading part is that when an identity is created, the associated mailbox is not.

<!-- gh-comment-id:703097628 --> @dirtyhillbilly commented on GitHub (Oct 3, 2020): I have the same problem. The misleading part is that when an identity is created, the associated mailbox is not.
kerem commented 2026-02-27 11:13:17 +03:00
Author
Owner
Copy link

@tonioo commented on GitHub (Oct 5, 2020):

@dirtyhillbilly Can you provide the file you used for import?

<!-- gh-comment-id:703440969 --> @tonioo commented on GitHub (Oct 5, 2020): @dirtyhillbilly Can you provide the file you used for import?
kerem commented 2026-02-27 11:13:17 +03:00
Author
Owner
Copy link

@dirtyhillbilly commented on GitHub (Oct 6, 2020):

The file I used lacked the "address" part, thus creating the account didn't create the mailbox.
Things like that work as expected :

account;xxx@foo.net;{SHA512-CRYPT}$6$rounds=70000$fybLy/WWfW.I/fx3$yR2zDgcN549pE7EJelnYYuXA/TLO.m53ssk/eiajieVQF7/E5B3hAyD6456sdGf3KvxZuEhQ1aQfZOzaB1407.;firstname;lastname;SimpleUser;True;xxx@foo.net
<!-- gh-comment-id:704085182 --> @dirtyhillbilly commented on GitHub (Oct 6, 2020): The file I used lacked the "address" part, thus creating the account didn't create the mailbox. Things like that work as expected : ``` account;xxx@foo.net;{SHA512-CRYPT}$6$rounds=70000$fybLy/WWfW.I/fx3$yR2zDgcN549pE7EJelnYYuXA/TLO.m53ssk/eiajieVQF7/E5B3hAyD6456sdGf3KvxZuEhQ1aQfZOzaB1407.;firstname;lastname;SimpleUser;True;xxx@foo.net ```
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
fix/sievefilters-allow-email-in-rule-name
dependabot/npm_and_yarn/frontend/axios-1.15.0
translations_04c0b653215cb5fa48ab101eae1a1917_ja_JP
translations_5d93982e9fd6dab991db4faf93ce9ded_ja_JP
fix/login-issue-3995
fix/sievefilters-issues
add-vitepress-openapi
2974-dmarc-empty-email
2.3.x
updated-doc-2.3.0
feature/OIDC
delete-all-alarms
translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_af_ZA
translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_ar
translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_ca
1.x
translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_sk
translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_tr
translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_es_ES
translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_uk
translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_zh_CN
translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_de_DE
translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_da_DK
1.8.x
1.7.x
1.6.x
1.4.x
1.3.x
1.2.x
2.8.2
2.8.1
2.8.0
2.7.2
2.7.1
2.7.0
2.6.5
2.6.4
2.6.3
2.6.2
2.6.1
2.6.0
2.5.1
2.5.0
2.4.11
2.4.10
2.4.9
2.4.8
2.4.7
2.4.6
2.4.5
2.4.4
2.4.3
2.4.2
2.4.1
2.4.0
2.3.6
2.3.5
2.3.4
2.3.3
2.3.2
2.3.1
2.3.0
2.3.0-beta.4
2.3.0-beta.3
2.3.0-beta.2
2.3.0-beta.1
2.2.4
2.2.3
2.2.2
2.2.1
2.2.0
2.1.2
2.1.1
2.1.0
2.0.5
2.0.4
2.0.3
2.0.2
2.0.1
2.0.0
2.0.0-beta.3
2.0.0-beta.2
2.0.0-beta.1
1.17.0
1.16.1
1.16.0
1.15.0
1.14.0
1.13.1
1.13.0
1.12.2
1.12.1
1.12.0
1.11.1
1.11.0
1.10.7
1.10.6
1.10.5
1.10.4
1.10.3
1.10.2
1.10.1
1.10.0
1.9.1
1.9.0
1.8.3
1.8.2
1.8.1
1.8.0
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.3
1.6.2
1.6.1
1.6.0
1.5.3
1.5.2
1.5.1
1.5.0
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.5
1.3.4
1.2.2
1.3.3
1.3.2
1.3.1
1.3.0
1.2.1
1.2.0
1.2.0-rc2
1.2.0-rc1
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.1
1.0.0
0.9.5
0.9.4
0.9.3
0.9.2
0.9.1
0.9
0.8.8
0.8.7
0.8.6.1
0.8.6
0.8.5
0.8.4
0.8.3
0.8.3-rc1
0.8.2
0.8.1
0.8
0.8-rc2
0.8-rc1
0.7.2
0.7.1
0.7
0.6.1
0.6
0.5
0.3
0.2
0.1
Labels
Clear labels   
bug

   
bug

   
dependencies

   
design

   
documentation

   
duplicate

   
enhancement

   
enhancement

   
enhancement

   
feedback-needed

   
help-needed

   
help-needed

   
installer

   
invalid

   
looking-for-sponsors

   
modoboa-contacts

   
new-ui

   
new-ui

   
pr

   
pull-request

Mirrored from GitHub Pull Request

  
pyconfr

   
python

   
question

   
security

   
stale

   
webmail

   
wontfix
No labels
bug
bug
dependencies
design
documentation
duplicate
enhancement
enhancement
enhancement
feedback-needed
help-needed
help-needed
installer
invalid
looking-for-sponsors
modoboa-contacts
new-ui
new-ui
pr
pull-request
pyconfr
python
question
security
stale
webmail
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/modoboa-modoboa#732
No description provided.