[GH-ISSUE #456] Disabling email links does not work #439

New issue

Closed

opened 2026-02-27 11:11:47 +03:00 by kerem · 3 comments

kerem commented

2026-02-27 11:11:47 +03:00

Owner

Originally created by @tonioo on GitHub (Dec 4, 2013).
Original GitHub issue: https://github.com/modoboa/modoboa/issues/456

Originally assigned to: @tonioo on GitHub.

Originally created by Miroslav Abrahám on 2013-09-07T21:31:22Z

When a user has an email displayed, he has 2 options concerning displaying links - one can either activate them or disable them.
Activation works fine but clicking on disabling links exists the email.

This patch fixes the activation/disabling:

--- webmail.js.old      2013-09-07 23:26:37.418712830 +0200
+++ webmail.js  2013-09-07 23:26:49.182712213 +0200
@@ -83,7 +83,7 @@
         $(document).on("click", "a[name=forward]", $.proxy(this.reply_loader, this));
         $(document).on("click", "a[name=delete]", $.proxy(this.delete_message, this));
         $(document).on("click", "a[name=activate_links]", $.proxy(function(e) { this.display_mode(e, "1"); }, this));
-        $(document).on("click", "a[name=disable_links]", $.proxy(function(e) { this.disable_mode(e, "0"); }, this));
+        $(document).on("click", "a[name=disable_links]", $.proxy(function(e) { this.display_mode(e, "0"); }, this));

         $(document).on("click", "a[name=sendmail]", $.proxy(this.sendmail, this));

Originally created by @tonioo on GitHub (Dec 4, 2013). Original GitHub issue: https://github.com/modoboa/modoboa/issues/456 Originally assigned to: @tonioo on GitHub. **Originally created by Miroslav Abrahám on 2013-09-07T21:31:22Z** When a user has an email displayed, he has 2 options concerning displaying links - one can either activate them or disable them. Activation works fine but clicking on disabling links exists the email. This patch fixes the activation/disabling: <pre> --- webmail.js.old 2013-09-07 23:26:37.418712830 +0200 +++ webmail.js 2013-09-07 23:26:49.182712213 +0200 @@ -83,7 +83,7 @@ $(document).on("click", "a[name=forward]", $.proxy(this.reply_loader, this)); $(document).on("click", "a[name=delete]", $.proxy(this.delete_message, this)); $(document).on("click", "a[name=activate_links]", $.proxy(function(e) { this.display_mode(e, "1"); }, this)); - $(document).on("click", "a[name=disable_links]", $.proxy(function(e) { this.disable_mode(e, "0"); }, this)); + $(document).on("click", "a[name=disable_links]", $.proxy(function(e) { this.display_mode(e, "0"); }, this)); $(document).on("click", "a[name=sendmail]", $.proxy(this.sendmail, this)); </pre>

kerem

2026-02-27 11:11:47 +03:00

closed this issue
added the
bug
label

kerem commented

2026-02-27 11:11:48 +03:00

Author

Owner

@tonioo commented on GitHub (Dec 4, 2013):

Posted by Miroslav Abrahám on 2013-09-07T21:33:13Z

Obviously a wrong name for the task. It should have been "disabling email links does not work".

@tonioo commented on GitHub (Dec 4, 2013): **Posted by Miroslav Abrahám on 2013-09-07T21:33:13Z** Obviously a wrong name for the task. It should have been "disabling email links does not work".

kerem commented

2026-02-27 11:11:48 +03:00

Author

Owner

@tonioo commented on GitHub (Dec 4, 2013):

Posted by Antoine Nguyen on 2013-09-08T19:22:43Z

Hi, thanks for this patch. I'll apply it tomorrow.

@tonioo commented on GitHub (Dec 4, 2013): **Posted by Antoine Nguyen on 2013-09-08T19:22:43Z** Hi, thanks for this patch. I'll apply it tomorrow.

kerem commented

2026-02-27 11:11:48 +03:00

Author

Owner

@tonioo commented on GitHub (Dec 4, 2013):

Posted by Antoine Nguyen on 2013-09-09T19:39:26Z

Applied in changeset commit:c509cb4edec50709a0dd8bf24b696a63488d6e7d.

@tonioo commented on GitHub (Dec 4, 2013): **Posted by Antoine Nguyen on 2013-09-09T19:39:26Z** Applied in changeset commit:c509cb4edec50709a0dd8bf24b696a63488d6e7d.