[GH-ISSUE #307] Parsing the X-Amavis-Alert field sometime fails #291

Closed
opened 2026-02-27 11:11:01 +03:00 by kerem · 5 comments
Owner

Originally created by @tonioo on GitHub (Dec 4, 2013).
Original GitHub issue: https://github.com/modoboa/modoboa/issues/307

Originally assigned to: @tonioo on GitHub.

Originally created by Antoine Nguyen on 2012-09-26T19:49:40Z

Encountered exception:

Exception Type:     ValueError
Exception Value:    

need more than 1 value to unpack

Exception Location:     /usr/local/lib/python2.7/dist-packages/modoboa-0.9.2-py2.7.egg/modoboa/extensions/amavis/sql_listing.py in __init__, line 115

It is happening because Amavis not always put a ',' separator in this header. It will be fixed on Amavis side soon but we need to be more robust against such issues.

Originally created by @tonioo on GitHub (Dec 4, 2013). Original GitHub issue: https://github.com/modoboa/modoboa/issues/307 Originally assigned to: @tonioo on GitHub. **Originally created by Antoine Nguyen on 2012-09-26T19:49:40Z** Encountered exception: <pre> Exception Type: ValueError Exception Value: need more than 1 value to unpack Exception Location: /usr/local/lib/python2.7/dist-packages/modoboa-0.9.2-py2.7.egg/modoboa/extensions/amavis/sql_listing.py in __init__, line 115 </pre> It is happening because Amavis not always put a ',' separator in this header. It will be fixed on Amavis side soon but we need to be more robust against such issues.
kerem 2026-02-27 11:11:01 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@tonioo commented on GitHub (Dec 4, 2013):

Posted by Antoine Nguyen on 2012-09-29T13:59:18Z

Hi Louis-Dominique,

could you please confirm me this fix works for you ?

Antoine

<!-- gh-comment-id:29815833 --> @tonioo commented on GitHub (Dec 4, 2013): **Posted by Antoine Nguyen on 2012-09-29T13:59:18Z** Hi Louis-Dominique, could you please confirm me this fix works for you ? Antoine
Author
Owner

@tonioo commented on GitHub (Dec 4, 2013):

Posted by Louis-Dominique Dubeau on 2012-09-29T15:09:47Z

Antoine Nguyen wrote:

could you please confirm me this fix works for you ?

Are you suggesting I install the development version? Is there a suggested procedure? I've read upgrade.rst but did not see there anything specific to 0.9.3.

Also, it may take a while before I get an email that would trigger this specific problem.

<!-- gh-comment-id:29815837 --> @tonioo commented on GitHub (Dec 4, 2013): **Posted by Louis-Dominique Dubeau on 2012-09-29T15:09:47Z** Antoine Nguyen wrote: > could you please confirm me this fix works for you ? Are you suggesting I install the development version? Is there a suggested procedure? I've read upgrade.rst but did not see there anything specific to 0.9.3. Also, it may take a while before I get an email that would trigger this specific problem.
Author
Owner

@tonioo commented on GitHub (Dec 4, 2013):

Posted by Antoine Nguyen on 2012-09-29T15:21:25Z

Louis-Dominique Dubeau wrote:

Antoine Nguyen wrote:

could you please confirm me this fix works for you ?

Are you suggesting I install the development version? Is there a suggested procedure? I've read upgrade.rst but did not see there anything specific to 0.9.3.

Also, it may take a while before I get an email that would trigger this specific problem.

You didn't keep it into the quarantine? I haven't got such a message so I can't easily check this fix...

The development version is close to be the 0.9.3 and it is mainly a bugfixes release. Since 0.9.1, migrating a modo installation is a lot more simple (http://docs.modoboa.org/getting_started/upgrade.html#latest-version).

If you want to install a devel version:

$ hg clone http://dev.modoboa.org/hg/modoboa
$ cd modoboa
$ python setup.py install

Then, just follow the documentation.

<!-- gh-comment-id:29815840 --> @tonioo commented on GitHub (Dec 4, 2013): **Posted by Antoine Nguyen on 2012-09-29T15:21:25Z** Louis-Dominique Dubeau wrote: > Antoine Nguyen wrote: > > > could you please confirm me this fix works for you ? > > Are you suggesting I install the development version? Is there a suggested procedure? I've read upgrade.rst but did not see there anything specific to 0.9.3. > > Also, it may take a while before I get an email that would trigger this specific problem. You didn't keep it into the quarantine? I haven't got such a message so I can't easily check this fix... The development version is close to be the 0.9.3 and it is mainly a _bugfixes_ release. Since 0.9.1, migrating a modo installation is a lot more simple (http://docs.modoboa.org/getting_started/upgrade.html#latest-version). If you want to install a devel version: <pre> $ hg clone http://dev.modoboa.org/hg/modoboa $ cd modoboa $ python setup.py install </pre> Then, just follow the documentation. </pre>
Author
Owner

@tonioo commented on GitHub (Dec 4, 2013):

Posted by Louis-Dominique Dubeau on 2012-10-05T14:43:57Z

Got a message with the bad headers. Works for me.

<!-- gh-comment-id:29815844 --> @tonioo commented on GitHub (Dec 4, 2013): **Posted by Louis-Dominique Dubeau on 2012-10-05T14:43:57Z** Got a message with the bad headers. Works for me.
Author
Owner

@tonioo commented on GitHub (Dec 4, 2013):

Posted by Antoine Nguyen on 2012-10-05T18:21:27Z

Great! Thx for your feedback :)

<!-- gh-comment-id:29815845 --> @tonioo commented on GitHub (Dec 4, 2013): **Posted by Antoine Nguyen on 2012-10-05T18:21:27Z** Great! Thx for your feedback :)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/modoboa-modoboa#291
No description provided.