[PR #2964] [MERGED] Better UX on failling to save parameters #2844

New issue

Closed

opened 2026-02-27 12:13:01 +03:00 by kerem · 0 comments

kerem commented 2026-02-27 12:13:01 +03:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa/pull/2964
Author: @Spitfireap
Created: 4/23/2023
Status: ✅ Merged
Merged: 4/25/2023
Merged by: @tonioo

Base: master ← Head: frontend-parameters-qol

---

📝 Commits (4)

• 17bbd56 Better UX on failling to save parameters
• d3b7dbd Code cleaning
• 2f1d736 Added favicon for new-admin on build
• dfd2ea1 cleaning

📊 Changes

22 files changed (+1551 additions, -1306 deletions)

View changed files

📝 .gitignore (+1 -1)
📝 MANIFEST.in (+1 -0)
📝 frontend/locale/br/LC_MESSAGES/app.po (+78 -61)
📝 frontend/locale/cs/LC_MESSAGES/app.po (+78 -61)
📝 frontend/locale/de/LC_MESSAGES/app.po (+78 -61)
📝 frontend/locale/el/LC_MESSAGES/app.po (+78 -61)
📝 frontend/locale/en/LC_MESSAGES/app.po (+78 -61)
📝 frontend/locale/es/LC_MESSAGES/app.po (+78 -61)
📝 frontend/locale/fi/LC_MESSAGES/app.po (+78 -61)
📝 frontend/locale/fr/LC_MESSAGES/app.po (+129 -206)
📝 frontend/locale/it/LC_MESSAGES/app.po (+78 -61)
📝 frontend/locale/ja/LC_MESSAGES/app.po (+78 -61)
📝 frontend/locale/nl/LC_MESSAGES/app.po (+78 -61)
📝 frontend/locale/pl/LC_MESSAGES/app.po (+78 -61)
📝 frontend/locale/po/LC_MESSAGES/app.po (+78 -61)
📝 frontend/locale/pt-br/LC_MESSAGES/app.po (+78 -61)
📝 frontend/locale/pt/LC_MESSAGES/app.po (+78 -61)
📝 frontend/locale/ru/LC_MESSAGES/app.po (+78 -61)
📝 frontend/locale/sv/LC_MESSAGES/app.po (+78 -61)
📝 frontend/locale/tr/LC_MESSAGES/app.po (+78 -61)

...and 2 more files

📄 Description

• Added a notification when parameters fail to save and highlighted tabs with parameters containing errors in red:
  
• Updated translation

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa/pull/2964 **Author:** [@Spitfireap](https://github.com/Spitfireap) **Created:** 4/23/2023 **Status:** ✅ Merged **Merged:** 4/25/2023 **Merged by:** [@tonioo](https://github.com/tonioo) **Base:** `master` ← **Head:** `frontend-parameters-qol` --- ### 📝 Commits (4) - [`17bbd56`](https://github.com/modoboa/modoboa/commit/17bbd566a20fd3bae8766182dee4b7152c188a17) Better UX on failling to save parameters - [`d3b7dbd`](https://github.com/modoboa/modoboa/commit/d3b7dbd53ac3ffa825ff5e65661cd5b141a7a72a) Code cleaning - [`2f1d736`](https://github.com/modoboa/modoboa/commit/2f1d736097c9a49c970755562b0d768e7c240c9b) Added favicon for new-admin on build - [`dfd2ea1`](https://github.com/modoboa/modoboa/commit/dfd2ea1b61b9cca936c27757bf36a0f295ce06c4) cleaning ### 📊 Changes **22 files changed** (+1551 additions, -1306 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -1) 📝 `MANIFEST.in` (+1 -0) 📝 `frontend/locale/br/LC_MESSAGES/app.po` (+78 -61) 📝 `frontend/locale/cs/LC_MESSAGES/app.po` (+78 -61) 📝 `frontend/locale/de/LC_MESSAGES/app.po` (+78 -61) 📝 `frontend/locale/el/LC_MESSAGES/app.po` (+78 -61) 📝 `frontend/locale/en/LC_MESSAGES/app.po` (+78 -61) 📝 `frontend/locale/es/LC_MESSAGES/app.po` (+78 -61) 📝 `frontend/locale/fi/LC_MESSAGES/app.po` (+78 -61) 📝 `frontend/locale/fr/LC_MESSAGES/app.po` (+129 -206) 📝 `frontend/locale/it/LC_MESSAGES/app.po` (+78 -61) 📝 `frontend/locale/ja/LC_MESSAGES/app.po` (+78 -61) 📝 `frontend/locale/nl/LC_MESSAGES/app.po` (+78 -61) 📝 `frontend/locale/pl/LC_MESSAGES/app.po` (+78 -61) 📝 `frontend/locale/po/LC_MESSAGES/app.po` (+78 -61) 📝 `frontend/locale/pt-br/LC_MESSAGES/app.po` (+78 -61) 📝 `frontend/locale/pt/LC_MESSAGES/app.po` (+78 -61) 📝 `frontend/locale/ru/LC_MESSAGES/app.po` (+78 -61) 📝 `frontend/locale/sv/LC_MESSAGES/app.po` (+78 -61) 📝 `frontend/locale/tr/LC_MESSAGES/app.po` (+78 -61) _...and 2 more files_ </details> ### 📄 Description * Added a notification when parameters fail to save and highlighted tabs with parameters containing errors in red:  * Updated translation --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

kerem 2026-02-27 12:13:01 +03:00

• closed this issue
• added the
  pull-request
  label

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

master

fix/sievefilters-allow-email-in-rule-name

dependabot/npm_and_yarn/frontend/axios-1.15.0

translations_04c0b653215cb5fa48ab101eae1a1917_ja_JP

translations_5d93982e9fd6dab991db4faf93ce9ded_ja_JP

fix/login-issue-3995

fix/sievefilters-issues

add-vitepress-openapi

2974-dmarc-empty-email

2.3.x

updated-doc-2.3.0

feature/OIDC

delete-all-alarms

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_af_ZA

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_ar

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_ca

1.x

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_sk

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_tr

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_es_ES

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_uk

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_zh_CN

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_de_DE

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_da_DK

1.8.x

1.7.x

1.6.x

1.4.x

1.3.x

1.2.x

2.8.2

2.8.1

2.8.0

2.7.2

2.7.1

2.7.0

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6.0

2.5.1

2.5.0

2.4.11

2.4.10

2.4.9

2.4.8

2.4.7

2.4.6

2.4.5

2.4.4

2.4.3

2.4.2

2.4.1

2.4.0

2.3.6

2.3.5

2.3.4

2.3.3

2.3.2

2.3.1

2.3.0

2.3.0-beta.4

2.3.0-beta.3

2.3.0-beta.2

2.3.0-beta.1

2.2.4

2.2.3

2.2.2

2.2.1

2.2.0

2.1.2

2.1.1

2.1.0

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

2.0.0-beta.3

2.0.0-beta.2

2.0.0-beta.1

1.17.0

1.16.1

1.16.0

1.15.0

1.14.0

1.13.1

1.13.0

1.12.2

1.12.1

1.12.0

1.11.1

1.11.0

1.10.7

1.10.6

1.10.5

1.10.4

1.10.3

1.10.2

1.10.1

1.10.0

1.9.1

1.9.0

1.8.3

1.8.2

1.8.1

1.8.0

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.3

1.6.2

1.6.1

1.6.0

1.5.3

1.5.2

1.5.1

1.5.0

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.5

1.3.4

1.2.2

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.2.0-rc2

1.2.0-rc1

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.1

1.0.0

0.9.5

0.9.4

0.9.3

0.9.2

0.9.1

0.9

0.8.8

0.8.7

0.8.6.1

0.8.6

0.8.5

0.8.4

0.8.3

0.8.3-rc1

0.8.2

0.8.1

0.8

0.8-rc2

0.8-rc1

0.7.2

0.7.1

0.7

0.6.1

0.6

0.5

0.3

0.2

0.1

Labels

Clear labels   

bug

  

bug

  

dependencies

  

design

  

documentation

  

duplicate

  

enhancement

  

enhancement

  

enhancement

  

feedback-needed

  

help-needed

  

help-needed

  

installer

  

invalid

  

looking-for-sponsors

  

modoboa-contacts

  

new-ui

  

new-ui

  

pr

  

pull-request

Mirrored from GitHub Pull Request

  

pyconfr

  

python

  

question

  

security

  

stale

  

webmail

  

wontfix

No labels

bug

bug

dependencies

design

documentation

duplicate

enhancement

enhancement

enhancement

feedback-needed

help-needed

help-needed

installer

invalid

looking-for-sponsors

modoboa-contacts

new-ui

new-ui

pr

pull-request

pyconfr

python

question

security

stale

webmail

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/modoboa-modoboa#2844

No description provided.