starred/modoboa-modoboa

Fork 0

mirror of https://github.com/modoboa/modoboa.git synced 2026-04-26 01:16:01 +03:00

[GH-ISSUE #299] if amavis extension fails to contact amavis, there is no clear error message. #283

New issue

Closed

opened 2026-02-27 11:10:59 +03:00 by kerem · 4 comments

kerem commented

2026-02-27 11:10:59 +03:00

Owner

Originally created by @tonioo on GitHub (Dec 4, 2013).
Original GitHub issue: https://github.com/modoboa/modoboa/issues/299

Originally assigned to: @tonioo on GitHub.

Originally created by Louis-Dominique Dubeau on 2012-09-03T17:17:13Z

Version: modoboa 0.9.2

Actual behavior: As of the date of this bug report, if Modoboa's amavis extension is unable to contact amavis to release an email from quarantine, the failure will occur silently. Initial investigation suggests that an exception is not trapped in the AMrelease object (in amavis/lib.py).

Expected behavior: It would be desirable for Modoboa to trap the failure and be vocal about it so that a) the user knows something went wrong and b) a sysadmin takes care of the problem.

Suggestions:

On the screen where the administrator sets the parameters for the amavis extension, provide the capability to test communications with amavis.
Use django's logging facility to log failures.
When a user releases a message and the release fails, give an informative error message.

Reference to the discussion in Google Groups:

https://groups.google.com/forum/#!topic/modoboa-users/fOxYhCDyw_o

Originally created by @tonioo on GitHub (Dec 4, 2013). Original GitHub issue: https://github.com/modoboa/modoboa/issues/299 Originally assigned to: @tonioo on GitHub. **Originally created by Louis-Dominique Dubeau on 2012-09-03T17:17:13Z** Version: modoboa 0.9.2 Actual behavior: As of the date of this bug report, if Modoboa's amavis extension is unable to contact amavis to release an email from quarantine, the failure will occur silently. Initial investigation suggests that an exception is not trapped in the AMrelease object (in amavis/lib.py). Expected behavior: It would be desirable for Modoboa to trap the failure and be vocal about it so that a) the user knows something went wrong and b) a sysadmin takes care of the problem. Suggestions: 1. On the screen where the administrator sets the parameters for the amavis extension, provide the capability to test communications with amavis. 2. Use django's logging facility to log failures. 3. When a user releases a message and the release fails, give an informative error message. Reference to the discussion in Google Groups: https://groups.google.com/forum/#!topic/modoboa-users/fOxYhCDyw_o

kerem

2026-02-27 11:10:59 +03:00

closed this issue
added the
bug
label

kerem commented

2026-02-27 11:11:00 +03:00

Author

Owner

@tonioo commented on GitHub (Dec 4, 2013):

Posted by Antoine Nguyen on 2012-09-19T15:35:52Z

Hi,

I've added a simple error message (step 3 in your list). I wonder if the step 2 is necessary now that we have step 3. What do you think ?

About step 1, I'm going to create a new dedicated ticket. I generaly apply this rule : 1 feature/bug == 1 ticket.

Antoine

@tonioo commented on GitHub (Dec 4, 2013): **Posted by Antoine Nguyen on 2012-09-19T15:35:52Z** Hi, I've added a simple error message (step 3 in your list). I wonder if the step 2 is necessary now that we have step 3. What do you think ? About step 1, I'm going to create a new dedicated ticket. I generaly apply this rule : 1 feature/bug == 1 ticket. Antoine

kerem commented

2026-02-27 11:11:00 +03:00

Author

Owner

@tonioo commented on GitHub (Dec 4, 2013):

Posted by Louis-Dominique Dubeau on 2012-09-20T12:33:48Z

Antoine Nguyen wrote:

Hi,

I've added a simple error message (step 3 in your list). I wonder if the step 2 is necessary now that we have step 3. What do you think ?

I can conceive of scenarios where having item 2 implemented would help a sysadmin diagnose problems, but I do not know whether in practice it would be all that useful.

About step 1, I'm going to create a new dedicated ticket. I generaly apply this rule : 1 feature/bug == 1 ticket.

Make sense.

@tonioo commented on GitHub (Dec 4, 2013): **Posted by Louis-Dominique Dubeau on 2012-09-20T12:33:48Z** Antoine Nguyen wrote: > Hi, > > I've added a simple error message (step 3 in your list). I wonder if the step 2 is necessary now that we have step 3. What do you think ? I can conceive of scenarios where having item 2 implemented would help a sysadmin diagnose problems, but I do not know whether in practice it would be all that useful. > About step 1, I'm going to create a new dedicated ticket. I generaly apply this rule : 1 feature/bug == 1 ticket. Make sense.

kerem commented

2026-02-27 11:11:00 +03:00

Author

Owner

@tonioo commented on GitHub (Dec 4, 2013):

Posted by Louis-Dominique Dubeau on 2012-09-20T12:38:45Z

Oops. In my previous note I meant to write "[it] makes sense", i.e. what you wrote makes sense. The typo (lack of final "s") makes it sound like I'm using the imperative mood, which was not my intent.

@tonioo commented on GitHub (Dec 4, 2013): **Posted by Louis-Dominique Dubeau on 2012-09-20T12:38:45Z** Oops. In my previous note I meant to write "[it] makes sense", i.e. what you wrote makes sense. The typo (lack of final "s") makes it sound like I'm using the imperative mood, which was not my intent.

kerem commented

2026-02-27 11:11:00 +03:00

Author

Owner

@tonioo commented on GitHub (Dec 4, 2013):

Posted by Antoine Nguyen on 2012-09-20T20:37:03Z

Louis-Dominique Dubeau wrote:

Oops. In my previous note I meant to write "[it] makes sense", i.e. what you wrote makes sense. The typo (lack of final "s") makes it sound like I'm using the imperative mood, which was not my intent.

No problem, I noticed the mistake ;)

Anyway, I won't add logging support for now. I think that, if I do it, it must be something general.

@tonioo commented on GitHub (Dec 4, 2013): **Posted by Antoine Nguyen on 2012-09-20T20:37:03Z** Louis-Dominique Dubeau wrote: > Oops. In my previous note I meant to write "[it] makes sense", i.e. what you wrote makes sense. The typo (lack of final "s") makes it sound like I'm using the imperative mood, which was not my intent. No problem, I noticed the mistake ;) Anyway, I won't add logging support for now. I think that, if I do it, it must be something general.