[PR #2884] [MERGED] Added an alarm on dkim write error, reworked alarms #2780

New issue

Closed

opened 2026-02-27 12:12:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 12:12:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa/pull/2884
Author: @Spitfireap
Created: 2/24/2023
Status: ✅ Merged
Merged: 3/26/2023
Merged by: @tonioo

Base: master ← Head: better-dkim

📝 Commits (9)

2ad5bd2 reworked alarms, added alarm on dkim issue
2ebe8fe Added tests
e7257e2 Added tests
329ea62 Updated test
5ab5c90 Last tests
800cdad Even better tests
8807fcd Endpoint result is paginated.
5558dfb Fix review
29609e3 Added bulk delete endpoint for alarms

📊 Changes

16 files changed (+367 additions, -10 deletions)

View changed files

📝 frontend/src/App.vue (+40 -1)
📝 frontend/src/api/alarms.js (+9 -0)
📝 frontend/src/components/alarms/AlarmList.vue (+86 -2)
➕ frontend/src/constants.json (+4 -0)
📝 frontend/src/views/Login.vue (+2 -0)
📝 frontend/vue.config.js (+1 -1)
📝 modoboa/admin/api/v2/serializers.py (+15 -0)
📝 modoboa/admin/api/v2/tests.py (+76 -1)
📝 modoboa/admin/api/v2/viewsets.py (+49 -2)
📝 modoboa/admin/constants.py (+2 -0)
📝 modoboa/admin/management/commands/subcommands/_manage_dkim_keys.py (+15 -0)
📝 modoboa/admin/models/alarm.py (+6 -0)
📝 modoboa/admin/models/mxrecord.py (+1 -1)
➕ modoboa/admin/tests/test_alarms.py (+26 -0)
📝 modoboa/admin/tests/test_domain.py (+23 -2)
📝 modoboa/parameters/api/v2/tests.py (+12 -0)

📄 Description

As stated in #2768, modoboa did not check for the write permission of the dkim dir. If the user manages to set the parameter to a non-writable dir, an alarm will be created.

Also alarm page has been reworked (fixed alarms not displaying, added actions to open/close/delete and alarm, added a bulk action)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa/pull/2884 **Author:** [@Spitfireap](https://github.com/Spitfireap) **Created:** 2/24/2023 **Status:** ✅ Merged **Merged:** 3/26/2023 **Merged by:** [@tonioo](https://github.com/tonioo) **Base:** `master` ← **Head:** `better-dkim` --- ### 📝 Commits (9) - [`2ad5bd2`](https://github.com/modoboa/modoboa/commit/2ad5bd283dfa56f0ab3f520896eb897a8c14eb3f) reworked alarms, added alarm on dkim issue - [`2ebe8fe`](https://github.com/modoboa/modoboa/commit/2ebe8fea439d4b0c22c4dddf198f2fd45db918a4) Added tests - [`e7257e2`](https://github.com/modoboa/modoboa/commit/e7257e20f2ff518a613efa999cec5f2b0a831223) Added tests - [`329ea62`](https://github.com/modoboa/modoboa/commit/329ea62aac85c68bb358e8f4098f7e7544d7fbee) Updated test - [`5ab5c90`](https://github.com/modoboa/modoboa/commit/5ab5c9092710367ffcad0fb185c58db181eb76a3) Last tests - [`800cdad`](https://github.com/modoboa/modoboa/commit/800cdad11b7c371de439b308c270c4e0b7a9b67b) Even better tests - [`8807fcd`](https://github.com/modoboa/modoboa/commit/8807fcd94b91f41599525f9b09228e675d6ce5d8) Endpoint result is paginated. - [`5558dfb`](https://github.com/modoboa/modoboa/commit/5558dfba30492e2f282584511bbf1004fa295666) Fix review - [`29609e3`](https://github.com/modoboa/modoboa/commit/29609e3adbe23d0fc338606d631e1fa567b3e86e) Added bulk delete endpoint for alarms ### 📊 Changes **16 files changed** (+367 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/App.vue` (+40 -1) 📝 `frontend/src/api/alarms.js` (+9 -0) 📝 `frontend/src/components/alarms/AlarmList.vue` (+86 -2) ➕ `frontend/src/constants.json` (+4 -0) 📝 `frontend/src/views/Login.vue` (+2 -0) 📝 `frontend/vue.config.js` (+1 -1) 📝 `modoboa/admin/api/v2/serializers.py` (+15 -0) 📝 `modoboa/admin/api/v2/tests.py` (+76 -1) 📝 `modoboa/admin/api/v2/viewsets.py` (+49 -2) 📝 `modoboa/admin/constants.py` (+2 -0) 📝 `modoboa/admin/management/commands/subcommands/_manage_dkim_keys.py` (+15 -0) 📝 `modoboa/admin/models/alarm.py` (+6 -0) 📝 `modoboa/admin/models/mxrecord.py` (+1 -1) ➕ `modoboa/admin/tests/test_alarms.py` (+26 -0) 📝 `modoboa/admin/tests/test_domain.py` (+23 -2) 📝 `modoboa/parameters/api/v2/tests.py` (+12 -0) </details> ### 📄 Description As stated in #2768, modoboa did not check for the write permission of the dkim dir. If the user manages to set the parameter to a non-writable dir, an alarm will be created. Also alarm page has been reworked (fixed alarms not displaying, added actions to open/close/delete and alarm, added a bulk action) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>