[PR #2598] [MERGED] Fixed core parameters unable to save on v2 #2629

New issue

Closed

opened 2026-02-27 12:11:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 12:11:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa/pull/2598
Author: @Spitfireap
Created: 9/8/2022
Status: ✅ Merged
Merged: 9/17/2022
Merged by: @tonioo

Base: master ← Head: FixSaveParametersVue

📝 Commits (6)

0867eda Fixed core parameters unable to save on v2
a341198 Allow none (happens on fresh instance)
467dbec Updated test for real case
735d61e added fix for admin settings on fresh install
3b54c51 getting choices on init
f25fb7f PEP8 formating

📊 Changes

4 files changed (+18 additions, -7 deletions)

View changed files

📝 modoboa/admin/app_settings.py (+1 -0)
📝 modoboa/core/api/v2/serializers.py (+7 -3)
📝 modoboa/core/api/v2/tests.py (+1 -1)
📝 modoboa/core/sms_backends/ovh.py (+9 -3)

📄 Description

Description of the issue/feature this PR addresses:
fixes #2559
User can now save core parameters on new-admin.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa/pull/2598 **Author:** [@Spitfireap](https://github.com/Spitfireap) **Created:** 9/8/2022 **Status:** ✅ Merged **Merged:** 9/17/2022 **Merged by:** [@tonioo](https://github.com/tonioo) **Base:** `master` ← **Head:** `FixSaveParametersVue` --- ### 📝 Commits (6) - [`0867eda`](https://github.com/modoboa/modoboa/commit/0867eda8f7a02baf631382ecac98ec47dcdac06f) Fixed core parameters unable to save on v2 - [`a341198`](https://github.com/modoboa/modoboa/commit/a341198ce2448cf9ea7bcfdafa2f7704109d9873) Allow none (happens on fresh instance) - [`467dbec`](https://github.com/modoboa/modoboa/commit/467dbecaf22ed5147d3e2c4ed34a752cb98df0f4) Updated test for real case - [`735d61e`](https://github.com/modoboa/modoboa/commit/735d61ed08acc4c9281cfd6e613a4faa33c613b8) added fix for admin settings on fresh install - [`3b54c51`](https://github.com/modoboa/modoboa/commit/3b54c51b833c085d1c3737d536e01cfcdcc9e39f) getting choices on init - [`f25fb7f`](https://github.com/modoboa/modoboa/commit/f25fb7fbbc3cc7ce16748240c8b1a26fa60a667d) PEP8 formating ### 📊 Changes **4 files changed** (+18 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `modoboa/admin/app_settings.py` (+1 -0) 📝 `modoboa/core/api/v2/serializers.py` (+7 -3) 📝 `modoboa/core/api/v2/tests.py` (+1 -1) 📝 `modoboa/core/sms_backends/ovh.py` (+9 -3) </details> ### 📄 Description Description of the issue/feature this PR addresses: fixes #2559 User can now save core parameters on new-admin. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>