[PR #2582] [CLOSED] IPv6 and rDNS checks, updated DKIMKeyViewer on vue admin #2618

New issue

Closed

opened 2026-02-27 12:11:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 12:11:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa/pull/2582
Author: @Spitfireap
Created: 8/18/2022
Status: ❌ Closed

Base: master ← Head: newMXChecks

📝 Commits (7)

5378afa IPV6 and rDNS checks and setup instruction, quick copy dkim pub key for vue admin
ffe63c9 Fix some string errors
1264b71 Reformat dkimKeyViewer (no more overflow), allow to copy the key
68fb040 delete splitkey method
1c50687 removed useless css
86c07a9 Fixed bugs
ea1f8f4 comply with RFC 4408, added copy dkim for v1

📊 Changes

16 files changed (+278 additions, -20 deletions)

View changed files

📝 frontend/src/components/domains/DKIMKeyViewer.vue (+6 -3)
📝 frontend/src/components/domains/DNSDetail.vue (+28 -0)
📝 frontend/src/components/domains/DomainDKIMKey.vue (+24 -3)
📝 frontend/src/components/domains/DomainDNSConfig.vue (+25 -0)
📝 modoboa/admin/app_settings.py (+17 -0)
📝 modoboa/admin/management/commands/subcommands/_mx.py (+9 -0)
📝 modoboa/admin/models/domain.py (+29 -5)
📝 modoboa/admin/static/admin/css/admin.css (+15 -0)
📝 modoboa/admin/templates/admin/_domain_dkim_key.html (+4 -4)
📝 modoboa/admin/templates/admin/_domain_dnschecks_status.html (+31 -0)
📝 modoboa/admin/templates/admin/domain_detail.html (+8 -0)
📝 modoboa/admin/views/domain.py (+8 -2)
📝 modoboa/dnstools/api/v2/serializers.py (+5 -1)
📝 modoboa/dnstools/constants.py (+3 -0)
📝 modoboa/dnstools/lib.py (+60 -1)
📝 modoboa/dnstools/templates/dnstools/domain_dns_configuration.html (+6 -1)

📄 Description

This PR add checks for IPv6 set (pointed to mail.example.com.). As well as rDNS checks (for IPv4 and IPv6 if IPv6 checking is enabled).
I also refactored a bit the DKIMKeyViewer to prevent overflow of the v-alert, and added the ability to one-click copy it to clipboard.

Note: there are several migrations needed, it seems.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa/pull/2582 **Author:** [@Spitfireap](https://github.com/Spitfireap) **Created:** 8/18/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `newMXChecks` --- ### 📝 Commits (7) - [`5378afa`](https://github.com/modoboa/modoboa/commit/5378afab1002b1aa7239b48130b2e5354c5f59dc) IPV6 and rDNS checks and setup instruction, quick copy dkim pub key for vue admin - [`ffe63c9`](https://github.com/modoboa/modoboa/commit/ffe63c97bdfd5da20b6da15cd9e990b73d6042d3) Fix some string errors - [`1264b71`](https://github.com/modoboa/modoboa/commit/1264b719b391e36d2e27fdb001bc015dfe251314) Reformat dkimKeyViewer (no more overflow), allow to copy the key - [`68fb040`](https://github.com/modoboa/modoboa/commit/68fb0409773a6fe427176aee05be1b43c2b27294) delete splitkey method - [`1c50687`](https://github.com/modoboa/modoboa/commit/1c50687b0cecf547dbb4bbe508062e7f59841b80) removed useless css - [`86c07a9`](https://github.com/modoboa/modoboa/commit/86c07a9db7a6dd885ac2c4b82c28026bfe52858f) Fixed bugs - [`ea1f8f4`](https://github.com/modoboa/modoboa/commit/ea1f8f4c621fb2927b7fdd70344393d6f039f6ce) comply with RFC 4408, added copy dkim for v1 ### 📊 Changes **16 files changed** (+278 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/domains/DKIMKeyViewer.vue` (+6 -3) 📝 `frontend/src/components/domains/DNSDetail.vue` (+28 -0) 📝 `frontend/src/components/domains/DomainDKIMKey.vue` (+24 -3) 📝 `frontend/src/components/domains/DomainDNSConfig.vue` (+25 -0) 📝 `modoboa/admin/app_settings.py` (+17 -0) 📝 `modoboa/admin/management/commands/subcommands/_mx.py` (+9 -0) 📝 `modoboa/admin/models/domain.py` (+29 -5) 📝 `modoboa/admin/static/admin/css/admin.css` (+15 -0) 📝 `modoboa/admin/templates/admin/_domain_dkim_key.html` (+4 -4) 📝 `modoboa/admin/templates/admin/_domain_dnschecks_status.html` (+31 -0) 📝 `modoboa/admin/templates/admin/domain_detail.html` (+8 -0) 📝 `modoboa/admin/views/domain.py` (+8 -2) 📝 `modoboa/dnstools/api/v2/serializers.py` (+5 -1) 📝 `modoboa/dnstools/constants.py` (+3 -0) 📝 `modoboa/dnstools/lib.py` (+60 -1) 📝 `modoboa/dnstools/templates/dnstools/domain_dns_configuration.html` (+6 -1) </details> ### 📄 Description This PR add checks for IPv6 set (pointed to mail.example.com.). As well as rDNS checks (for IPv4 and IPv6 if IPv6 checking is enabled). I also refactored a bit the DKIMKeyViewer to prevent overflow of the v-alert, and added the ability to one-click copy it to clipboard. Note: there are several migrations needed, it seems. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>