[PR #2576] [MERGED] Mitigate spamhaus dns fail while querying for dnsbl #2615

New issue

Closed

opened 2026-02-27 12:11:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 12:11:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa/pull/2576
Author: @Spitfireap
Created: 7/29/2022
Status: ✅ Merged
Merged: 10/3/2022
Merged by: @tonioo

Base: master ← Head: dnsblprovider

📝 Commits (5)

ed9e12d mitigate spamhaus dns fail while querying for dnsbl
e662fd9 More generic dnsbl validation
4a1f1dc fix comment
8ae289a fixed mistake, updated test with real response possibility
4690824 make codecov happy

📊 Changes

2 files changed (+19 additions, -1 deletions)

View changed files

📝 modoboa/admin/management/commands/subcommands/_mx.py (+5 -0)
📝 modoboa/admin/tests/test_mx.py (+14 -1)

📄 Description

Kind of same mitigation as modoboa/modoboa-installer#426 but for dnsbl check.

I would be more in favor to simply drop spamhaus from dnsbl provider, but this could be a simple mitigation in case the user didn't set a dns resolver with rDNS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa/pull/2576 **Author:** [@Spitfireap](https://github.com/Spitfireap) **Created:** 7/29/2022 **Status:** ✅ Merged **Merged:** 10/3/2022 **Merged by:** [@tonioo](https://github.com/tonioo) **Base:** `master` ← **Head:** `dnsblprovider` --- ### 📝 Commits (5) - [`ed9e12d`](https://github.com/modoboa/modoboa/commit/ed9e12d2f75a8309e1ad88e69143abf7a820d542) mitigate spamhaus dns fail while querying for dnsbl - [`e662fd9`](https://github.com/modoboa/modoboa/commit/e662fd943db5b2fdb0ad917d0005c6a4bcf3c559) More generic dnsbl validation - [`4a1f1dc`](https://github.com/modoboa/modoboa/commit/4a1f1dc5d3716c4b1cdce70f6ced3ba2c98fc482) fix comment - [`8ae289a`](https://github.com/modoboa/modoboa/commit/8ae289ad3124eec82ee5ad5687ed7df14141acf6) fixed mistake, updated test with real response possibility - [`4690824`](https://github.com/modoboa/modoboa/commit/46908249698e6ff52a217145b56c9c20d8df54e9) make codecov happy ### 📊 Changes **2 files changed** (+19 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `modoboa/admin/management/commands/subcommands/_mx.py` (+5 -0) 📝 `modoboa/admin/tests/test_mx.py` (+14 -1) </details> ### 📄 Description Kind of same mitigation as modoboa/modoboa-installer#426 but for dnsbl check. I would be more in favor to simply drop spamhaus from dnsbl provider, but this could be a simple mitigation in case the user didn't set a dns resolver with rDNS. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>