[PR #2257] [CLOSED] Fixed a bug that was preventing modoboa from properly importing users from an LDAP connection. (modoboa#2239) #2490

New issue

Closed

opened 2026-02-27 12:11:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 12:11:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa/pull/2257
Author: @ScionOfDesign
Created: 6/3/2021
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (2)

e795708 Fixed a bug that was preventing modoboa from properly importing users from an LDAP connection. (modoboa#2239)
bd99b68 Added an example of some additional functionality I'd like to see.

📊 Changes

3 files changed (+28 additions, -11 deletions)

View changed files

📝 modoboa/core/app_settings.py (+13 -5)
📝 modoboa/core/models.py (+2 -2)
📝 modoboa/core/views/auth.py (+13 -4)

📄 Description

Description of the issue/feature this PR addresses:
The configuration parameter ldap_enable_sync was being queried when it should have been ldap_enable_import. (modoboa#2239)
This caused modoboa to attempt to login to the LDAP server with an empty password in an attempt to change said password.

Current behavior before PR:
modoboa would throw an INVALID_CREDENTIALS error from failing to login to the LDAP server with an empty password.

Desired behavior after PR is merged:
modoboa will successfully update the local password to match the remote LDAP password.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa/pull/2257 **Author:** [@ScionOfDesign](https://github.com/ScionOfDesign) **Created:** 6/3/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`e795708`](https://github.com/modoboa/modoboa/commit/e7957081b10357ccf43a373035d2058d3ba96caf) Fixed a bug that was preventing modoboa from properly importing users from an LDAP connection. (modoboa#2239) - [`bd99b68`](https://github.com/modoboa/modoboa/commit/bd99b686cbe9be3c74837f10cd2909355b53e8d3) Added an example of some additional functionality I'd like to see. ### 📊 Changes **3 files changed** (+28 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `modoboa/core/app_settings.py` (+13 -5) 📝 `modoboa/core/models.py` (+2 -2) 📝 `modoboa/core/views/auth.py` (+13 -4) </details> ### 📄 Description Description of the issue/feature this PR addresses: The configuration parameter `ldap_enable_sync` was being queried when it should have been `ldap_enable_import`. (modoboa#2239) This caused modoboa to attempt to login to the LDAP server with an empty password in an attempt to change said password. Current behavior before PR: modoboa would throw an `INVALID_CREDENTIALS ` error from failing to login to the LDAP server with an empty password. Desired behavior after PR is merged: modoboa will successfully update the local password to match the remote LDAP password. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>