[PR #1814] [MERGED] Fix account removal from domain admins #2299

New issue

Closed

opened 2026-02-27 12:10:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 12:10:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa/pull/1814
Author: @jeromelebleu
Created: 1/3/2020
Status: ✅ Merged
Merged: 1/6/2020
Merged by: @tonioo

Base: master ← Head: fix-domain-admins

📝 Commits (1)

2b23f5a admin: fix account removal from domain admins

📊 Changes

2 files changed (+34 additions, -4 deletions)

View changed files

📝 modoboa/admin/forms/account.py (+1 -2)
📝 modoboa/admin/tests/test_account.py (+33 -2)

📄 Description

Current behavior before PR

In the account edition modal for a user with DomainAdmins role, removing a domain from its permissions is not considered when the form is submitted. The user is still an admin for the domain.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa/pull/1814 **Author:** [@jeromelebleu](https://github.com/jeromelebleu) **Created:** 1/3/2020 **Status:** ✅ Merged **Merged:** 1/6/2020 **Merged by:** [@tonioo](https://github.com/tonioo) **Base:** `master` ← **Head:** `fix-domain-admins` --- ### 📝 Commits (1) - [`2b23f5a`](https://github.com/modoboa/modoboa/commit/2b23f5a9be9274a418241d04fc86104bd9526966) admin: fix account removal from domain admins ### 📊 Changes **2 files changed** (+34 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `modoboa/admin/forms/account.py` (+1 -2) 📝 `modoboa/admin/tests/test_account.py` (+33 -2) </details> ### 📄 Description #### Current behavior before PR In the account edition modal for a user with *DomainAdmins* role, removing a domain from its permissions is not considered when the form is submitted. The user is still an admin for the domain. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>