[PR #1790] [MERGED] Fix exception handling in argon2 for mismatching passwords #2294

Closed
opened 2026-02-27 12:10:20 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa/pull/1790
Author: @Arvedui
Created: 11/12/2019
Status: Merged
Merged: 12/3/2019
Merged by: @tonioo

Base: masterHead: argon2_fix_password_mismatch


📝 Commits (1)

  • 672a702 Fix exception handling in argon2 for mismatching passwords

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 modoboa/core/password_hashers/advanced.py (+2 -1)

📄 Description

Description of the issue/feature this PR addresses:
Fix exception handling in argon2 for mismatching passwords

Current behavior before PR:
When the argon2 hasher is used and the given password does not match the hash, an "internal error" occurs.

Desired behavior after PR is merged:
The proper "invalid username or password" message is shown and now redirect to the error page happens.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa/pull/1790 **Author:** [@Arvedui](https://github.com/Arvedui) **Created:** 11/12/2019 **Status:** ✅ Merged **Merged:** 12/3/2019 **Merged by:** [@tonioo](https://github.com/tonioo) **Base:** `master` ← **Head:** `argon2_fix_password_mismatch` --- ### 📝 Commits (1) - [`672a702`](https://github.com/modoboa/modoboa/commit/672a702673124ce5557e385724be76f4b2df2321) Fix exception handling in argon2 for mismatching passwords ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `modoboa/core/password_hashers/advanced.py` (+2 -1) </details> ### 📄 Description Description of the issue/feature this PR addresses: Fix exception handling in argon2 for mismatching passwords Current behavior before PR: When the argon2 hasher is used and the given password does not match the hash, an "internal error" occurs. Desired behavior after PR is merged: The proper "invalid username or password" message is shown and now redirect to the error page happens. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 12:10:20 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/modoboa-modoboa#2294
No description provided.