[PR #1766] [CLOSED] dnstools dkim TXT record evaluation fix #2291

New issue

Closed

opened 2026-02-27 12:10:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 12:10:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa/pull/1766
Author: @tsabi
Created: 8/4/2019
Status: ❌ Closed

Base: master ← Head: master-dnstools-dkim-fix

📝 Commits (2)

1a1a732 Add Eclipse/PyDev files to gitignore
855e0e9 Fix DKIM TXT record evaluation

📊 Changes

2 files changed (+3 additions, -1 deletions)

View changed files

📝 .gitignore (+2 -0)
📝 modoboa/dnstools/lib.py (+1 -1)

📄 Description

Description of the issue/feature this PR addresses:
The DKIM button was red, but my TXT record setted well. So i looked about the issue, and i founded the evaluation of the TXT record is not good. According to DNS standard, a TXT record what is longer than 256 character need to split to several strings: https://help.directadmin.com/item.php?id=552

Current behavior before PR:
I just merge the splitted parts together.

Desired behavior after PR is merged:
The DKIM button is now green as it should be.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa/pull/1766 **Author:** [@tsabi](https://github.com/tsabi) **Created:** 8/4/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master-dnstools-dkim-fix` --- ### 📝 Commits (2) - [`1a1a732`](https://github.com/modoboa/modoboa/commit/1a1a732bde0e50bb067bf8cbb155d5835c444eb0) Add Eclipse/PyDev files to gitignore - [`855e0e9`](https://github.com/modoboa/modoboa/commit/855e0e985191ce7b810bff806043f7a0b3d53268) Fix DKIM TXT record evaluation ### 📊 Changes **2 files changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -0) 📝 `modoboa/dnstools/lib.py` (+1 -1) </details> ### 📄 Description Description of the issue/feature this PR addresses: The DKIM button was red, but my TXT record setted well. So i looked about the issue, and i founded the evaluation of the TXT record is not good. According to DNS standard, a TXT record what is longer than 256 character need to split to several strings: https://help.directadmin.com/item.php?id=552 Current behavior before PR: I just merge the splitted parts together. Desired behavior after PR is merged: The DKIM button is now green as it should be. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>