[PR #1690] [MERGED] Argon2 support #2283

New issue

Closed

opened 2026-02-27 12:10:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 12:10:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa/pull/1690
Author: @Arvedui
Created: 3/3/2019
Status: ✅ Merged
Merged: 3/19/2019
Merged by: @tonioo

Base: master ← Head: argon2

📝 Commits (6)

ab0926f add facilities to rehash on login passwords if parameters change
6145965 Implement support for the argon2 password hash
c4108a1 add basic test for argon2 hash
3e072de add test for rehash on login for parameter update
0a7a7a1 fixup! Implement support for the argon2 password hash
bd2ad0c fixup! add test for rehash on login for parameter update

📊 Changes

6 files changed (+113 additions, -3 deletions)

View changed files

📝 modoboa/core/password_hashers/__init__.py (+2 -1)
📝 modoboa/core/password_hashers/advanced.py (+49 -2)
📝 modoboa/core/password_hashers/base.py (+10 -0)
📝 modoboa/core/tests/test_authentication.py (+43 -0)
📝 modoboa/core/views/auth.py (+8 -0)
📝 requirements.txt (+1 -0)

📄 Description

Description of the issue/feature this PR addresses:
This PR implements support for the argon2 password hash and adds the ability to rehash passwords not only for schema changes but also for parameter changes. Right now the later is only implemented for argon2 hashes, but could also be interesting for sha{256,512}crypt hashes.

Current behavior before PR:
no argon2 support

Desired behavior after PR is merged:
working argon2 support with the ability to rehash password for parameter update on login

I have not (yet) written any documentation about the argon2 functionality. Because I'm unsure where it would fit best, any ideas?

#1673

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa/pull/1690 **Author:** [@Arvedui](https://github.com/Arvedui) **Created:** 3/3/2019 **Status:** ✅ Merged **Merged:** 3/19/2019 **Merged by:** [@tonioo](https://github.com/tonioo) **Base:** `master` ← **Head:** `argon2` --- ### 📝 Commits (6) - [`ab0926f`](https://github.com/modoboa/modoboa/commit/ab0926f916305bca30ce61de9c60fa96d58aafde) add facilities to rehash on login passwords if parameters change - [`6145965`](https://github.com/modoboa/modoboa/commit/61459651546146037f15fef1eab10c6144b511fd) Implement support for the argon2 password hash - [`c4108a1`](https://github.com/modoboa/modoboa/commit/c4108a1544b123567598766689b75cdec9928087) add basic test for argon2 hash - [`3e072de`](https://github.com/modoboa/modoboa/commit/3e072debadbbc49551479e89e1be6f95df4ae53b) add test for rehash on login for parameter update - [`0a7a7a1`](https://github.com/modoboa/modoboa/commit/0a7a7a10bba0e1035ca47f725195917595fc9cb4) fixup! Implement support for the argon2 password hash - [`bd2ad0c`](https://github.com/modoboa/modoboa/commit/bd2ad0ce3f0f8c2b1ba55306423b78fe0d535fd5) fixup! add test for rehash on login for parameter update ### 📊 Changes **6 files changed** (+113 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `modoboa/core/password_hashers/__init__.py` (+2 -1) 📝 `modoboa/core/password_hashers/advanced.py` (+49 -2) 📝 `modoboa/core/password_hashers/base.py` (+10 -0) 📝 `modoboa/core/tests/test_authentication.py` (+43 -0) 📝 `modoboa/core/views/auth.py` (+8 -0) 📝 `requirements.txt` (+1 -0) </details> ### 📄 Description Description of the issue/feature this PR addresses: This PR implements support for the argon2 password hash and adds the ability to rehash passwords not only for schema changes but also for parameter changes. Right now the later is only implemented for argon2 hashes, but could also be interesting for sha{256,512}crypt hashes. Current behavior before PR: no argon2 support Desired behavior after PR is merged: working argon2 support with the ability to rehash password for parameter update on login I have not (yet) written any documentation about the argon2 functionality. Because I'm unsure where it would fit best, any ideas? #1673 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>