[PR #1648] [MERGED] Bugfix: DKIM checks fail #2281

New issue

Closed

opened 2026-02-27 12:10:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 12:10:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa/pull/1648
Author: @jammo-nl
Created: 1/7/2019
Status: ✅ Merged
Merged: 1/9/2019
Merged by: @tonioo

Base: master ← Head: master

📝 Commits (2)

24e9534 Bugfix: DKIM checks fail
3aa14eb Add space to follow coding standards

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 modoboa/dnstools/lib.py (+1 -1)

📄 Description

Description of the issue/feature this PR addresses:
The DKIM key is base64 encoded, meaning it can end with "=" signs
Split on "=" and check if you have 2 'parts' (key and value) will fail in these cases.
By using split("=",1) we make sure we only slit on the first occurence of the "=" sign
(solves modoboa#1647 and partially modoboa#1640 and modoboa#1642)

Current behavior before PR:
DKIM checks fail

Desired behavior after PR is merged:
DKIM checks work

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa/pull/1648 **Author:** [@jammo-nl](https://github.com/jammo-nl) **Created:** 1/7/2019 **Status:** ✅ Merged **Merged:** 1/9/2019 **Merged by:** [@tonioo](https://github.com/tonioo) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`24e9534`](https://github.com/modoboa/modoboa/commit/24e9534378492b67804339007417f3a95462a69b) Bugfix: DKIM checks fail - [`3aa14eb`](https://github.com/modoboa/modoboa/commit/3aa14eb5011927947bbc7c83ca2ea7c9b6ae4e99) Add space to follow coding standards ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `modoboa/dnstools/lib.py` (+1 -1) </details> ### 📄 Description Description of the issue/feature this PR addresses: The DKIM key is base64 encoded, meaning it can end with "=" signs Split on "=" and check if you have 2 'parts' (key and value) will fail in these cases. By using split("=",1) we make sure we only slit on the first occurence of the "=" sign (solves modoboa#1647 and partially modoboa#1640 and modoboa#1642) Current behavior before PR: DKIM checks fail Desired behavior after PR is merged: DKIM checks work --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>