[PR #1445] [MERGED] revert #1439 changes #2228

New issue

Closed

opened 2026-02-27 12:09:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 12:09:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa/pull/1445
Author: @ghost
Created: 3/31/2018
Status: ✅ Merged
Merged: 4/2/2018
Merged by: @tonioo

Base: master ← Head: fix/1439

📝 Commits (2)

86d758d revert #1439 changes
f64cdb1 temporary solution for pip 10 internals moving to pip._internal

📊 Changes

3 files changed (+14 additions, -11 deletions)

View changed files

📝 dev-requirements.txt (+0 -1)
📝 setup.py (+14 -9)
📝 test-requirements.txt (+0 -1)

📄 Description

Adding external dependencies to setup.py was a bad idea, for now continue to use pip internal functions until a better solution can be found.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa/pull/1445 **Author:** [@ghost](https://github.com/ghost) **Created:** 3/31/2018 **Status:** ✅ Merged **Merged:** 4/2/2018 **Merged by:** [@tonioo](https://github.com/tonioo) **Base:** `master` ← **Head:** `fix/1439` --- ### 📝 Commits (2) - [`86d758d`](https://github.com/modoboa/modoboa/commit/86d758d841b24509d45dad5cb64056e5c9b26915) revert #1439 changes - [`f64cdb1`](https://github.com/modoboa/modoboa/commit/f64cdb1a93dc8cd706d47d63b288ba11e9a37a1c) temporary solution for pip 10 internals moving to pip._internal ### 📊 Changes **3 files changed** (+14 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `dev-requirements.txt` (+0 -1) 📝 `setup.py` (+14 -9) 📝 `test-requirements.txt` (+0 -1) </details> ### 📄 Description Adding external dependencies to `setup.py` was a bad idea, for now continue to use pip internal functions until a better solution can be found. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>