[PR #1333] [MERGED] Upgrade Django (Django-1.10 no longer supported) #2194

New issue

Closed

opened 2026-02-27 12:09:49 +03:00 by kerem · 0 comments

kerem commented 2026-02-27 12:09:49 +03:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa/pull/1333
Author: @ghost
Created: 12/19/2017
Status: ✅ Merged
Merged: 12/21/2017
Merged by: @tonioo

Base: master ← Head: upgrade-django

---

📝 Commits (10+)

• e6befb3 standardise travis.yml across modoboa extensions
• 3308c56 StopIterator has been depreciated, use return [PEP479]
• 892160d updates for django 1.11 support
• e8eb9a8 passlib 1.7 depreciated the use of .encrypt(), use .hash()
• 0cd444b django-reversion >= 2.0.0 should be used with django >= 1.8
• 2e18acb upgrade django-auth-ldap and fix depreciated warning
• ba86196 upgrade dependencies with minor version updates
• 8fb3e24 upgrade to django 1.11
• 4fe51d6 random code clean ups
• 33b37ec updated new deployment settings.py

📊 Changes

70 files changed (+300 additions, -241 deletions)

View changed files

📝 .travis.yml (+20 -13)
📝 ldap-requirements.txt (+1 -1)
📝 modoboa/admin/forms/account.py (+1 -3)
📝 modoboa/admin/forms/domain.py (+1 -1)
📝 modoboa/admin/handlers.py (+1 -1)
📝 modoboa/admin/migrations/0001_initial.py (+12 -12)
📝 modoboa/admin/models/alias.py (+7 -5)
📝 modoboa/admin/models/domain_alias.py (+2 -1)
📝 modoboa/admin/models/mailbox.py (+5 -4)
📝 modoboa/admin/models/mxrecord.py (+5 -5)
📝 modoboa/admin/templatetags/admin_tags.py (+1 -1)
📝 modoboa/admin/tests/test_account.py (+1 -1)
📝 modoboa/admin/tests/test_alias.py (+1 -1)
📝 modoboa/admin/tests/test_api.py (+1 -1)
📝 modoboa/admin/tests/test_domain.py (+1 -1)
📝 modoboa/admin/tests/test_domain_alias.py (+1 -1)
📝 modoboa/admin/tests/test_export.py (+1 -1)
📝 modoboa/admin/tests/test_import_.py (+1 -1)
📝 modoboa/admin/tests/test_mailbox_operations.py (+1 -1)
📝 modoboa/admin/tests/test_mx.py (+1 -1)

...and 50 more files

📄 Description

Django 1.10 is now no longer supported, this PR upgrades modoboa to Django 1.11 (the last version of Django to support Python 2). There's an associated PR for each of the extensions to upgrade them as well.

I've split this into several patches to make it easier to follow:

• e6befb3: make all the travis.yml settings the same across modoboa projects. Adds testing against Python 3.5 and enables most Python warnings, the warnings don't affect the test results but they do give you a heads up about things that are depreciated or wrong.

• 3308c56: PEP479 depreciated StopIterators, they should be replace with return.

• 892160d: fixes to support Django 1.11 (and 2.0)

  • MIDDLEWARE_CLASSES is replaced by MIDDLEWARE

  • add MiddlewareMixin to modoboa middlewares

  • on_delete will become a required parameter for ForeignKey() set it to the current default CASCADE

  • on_delete will become a required parameter for OneToOneField() set it to the current default CASCADE

  • reverse and reverse_lazy have moved to django.urls

  • RadioChoiceInput widget has been removed, replace with HorizontalRadioSelect

• e8eb9a8 0cd444b 2e18acb ba86196: upgrade dependencies and fix any errors/warnings.

• 8fb3e24: upgrade Django, the minimum version is pinned to 1.11.8 as this is the latest version that I've done the upgrade with.

• 4fe51d6: random code cleanups.

  • removed duplicate imports

  • whitespace fixes

  • removed unnecessary u"" prefixes

  • added missing r"" prefixes where required

  • added missing default values to DynamicForm() to prevent possible unassigned variable access

• 33b37ec: updated settings.py for new deployments

  • updated Django documentation urls to point to the current version

  • renamed MIDDLEWARE_CLASSES to MIDDLEWARE, MIDDLEWARE_CLASSES is depreciated in Django >= 1.10

  • whitespace and #noqa fixes

• 92963a0: updated test_project, synced with a fresh deployment using Django 1.11.8 and updated settings.py so the tests environment matches a fresh deployment.

---

There is one remaining warning for Django 2.0 support in urls.py (example):

RemovedInDjango20Warning: Specifying a namespace in django.conf.urls.include() without providing an app_name is deprecated. Set the app_name attribute in the included module, or pass a 2-tuple containing the list of patterns and app_name instead.

The simple fix from the description is to add app_name = "modoboa" to urls.py however this then requires every (and there's a lot of them) reverse("<url>") or reverse("<namespace>:<url>") to be prefixed with <app_name>. The documentation is very thin for this feature so I'm not sure what's the best solution, it's not a real issue until you upgrade to Django 2.0.

---

Extension PRs

• modoboa/modoboa-amavis#81
• modoboa/modoboa-contacts#11
• modoboa/modoboa-dmarc#28
• modoboa/modoboa-imap-migration#29
• modoboa/modoboa-pdfcredentials#25
• modoboa/modoboa-postfix-autoreply#52
• modoboa/modoboa-radicale#17
• modoboa/modoboa-sievefilters#25
• modoboa/modoboa-stats#36
• modoboa/modoboa-webmail#136

When this is merged extensions will need their requirements.txt updated to point at this version as a minimum for modobo.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa/pull/1333 **Author:** [@ghost](https://github.com/ghost) **Created:** 12/19/2017 **Status:** ✅ Merged **Merged:** 12/21/2017 **Merged by:** [@tonioo](https://github.com/tonioo) **Base:** `master` ← **Head:** `upgrade-django` --- ### 📝 Commits (10+) - [`e6befb3`](https://github.com/modoboa/modoboa/commit/e6befb3de92f6c65c9e496200014376d8c70bca3) standardise travis.yml across modoboa extensions - [`3308c56`](https://github.com/modoboa/modoboa/commit/3308c564807fbb069480238781caa89411e9031d) StopIterator has been depreciated, use return [PEP479] - [`892160d`](https://github.com/modoboa/modoboa/commit/892160d5aaa5c728c4dfef07db2293b739c38d3a) updates for django 1.11 support - [`e8eb9a8`](https://github.com/modoboa/modoboa/commit/e8eb9a84c1fc73a47ff596fd6b1e6eaab67a1980) passlib 1.7 depreciated the use of <hash>.encrypt(), use <hash>.hash() - [`0cd444b`](https://github.com/modoboa/modoboa/commit/0cd444be6b5dc6d42789fbaa4e9f89137d047f11) django-reversion >= 2.0.0 should be used with django >= 1.8 - [`2e18acb`](https://github.com/modoboa/modoboa/commit/2e18acb8ad251ddcf2f4b2a6afe975f5110df844) upgrade django-auth-ldap and fix depreciated warning - [`ba86196`](https://github.com/modoboa/modoboa/commit/ba861965b7d6d0bf48644993042c35ccb0102963) upgrade dependencies with minor version updates - [`8fb3e24`](https://github.com/modoboa/modoboa/commit/8fb3e244f63865741e1c30f53b39b757a92d15e4) upgrade to django 1.11 - [`4fe51d6`](https://github.com/modoboa/modoboa/commit/4fe51d6726d60d060a51051c65eada8bae1c5060) random code clean ups - [`33b37ec`](https://github.com/modoboa/modoboa/commit/33b37ec63e99169760c51e523f7e1969b18e9c4a) updated new deployment settings.py ### 📊 Changes **70 files changed** (+300 additions, -241 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+20 -13) 📝 `ldap-requirements.txt` (+1 -1) 📝 `modoboa/admin/forms/account.py` (+1 -3) 📝 `modoboa/admin/forms/domain.py` (+1 -1) 📝 `modoboa/admin/handlers.py` (+1 -1) 📝 `modoboa/admin/migrations/0001_initial.py` (+12 -12) 📝 `modoboa/admin/models/alias.py` (+7 -5) 📝 `modoboa/admin/models/domain_alias.py` (+2 -1) 📝 `modoboa/admin/models/mailbox.py` (+5 -4) 📝 `modoboa/admin/models/mxrecord.py` (+5 -5) 📝 `modoboa/admin/templatetags/admin_tags.py` (+1 -1) 📝 `modoboa/admin/tests/test_account.py` (+1 -1) 📝 `modoboa/admin/tests/test_alias.py` (+1 -1) 📝 `modoboa/admin/tests/test_api.py` (+1 -1) 📝 `modoboa/admin/tests/test_domain.py` (+1 -1) 📝 `modoboa/admin/tests/test_domain_alias.py` (+1 -1) 📝 `modoboa/admin/tests/test_export.py` (+1 -1) 📝 `modoboa/admin/tests/test_import_.py` (+1 -1) 📝 `modoboa/admin/tests/test_mailbox_operations.py` (+1 -1) 📝 `modoboa/admin/tests/test_mx.py` (+1 -1) _...and 50 more files_ </details> ### 📄 Description Django 1.10 is now [no longer supported](https://www.djangoproject.com/download/#supported-versions), this PR upgrades modoboa to Django 1.11 (the last version of Django to support Python 2). There's an associated PR for each of the extensions to upgrade them as well. I've split this into several patches to make it easier to follow: - e6befb3: make all the travis.yml settings the same across modoboa projects. Adds testing against Python 3.5 and enables *most* Python warnings, the warnings don't affect the test results but they do give you a heads up about things that are depreciated or wrong. - 3308c56: [PEP479](https://www.python.org/dev/peps/pep-0479/#consequences-for-existing-code) depreciated StopIterators, they should be replace with return. - 892160d: fixes to support Django 1.11 (and 2.0) - MIDDLEWARE_CLASSES is replaced by MIDDLEWARE - add MiddlewareMixin to modoboa middlewares - on_delete will become a required parameter for ForeignKey() set it to the current default CASCADE - on_delete will become a required parameter for OneToOneField() set it to the current default CASCADE - reverse and reverse_lazy have moved to django.urls - RadioChoiceInput widget has been removed, replace with HorizontalRadioSelect - e8eb9a8 0cd444b 2e18acb ba86196: upgrade dependencies and fix any errors/warnings. - 8fb3e24: upgrade Django, the minimum version is pinned to 1.11.8 as this is the latest version that I've done the upgrade with. - 4fe51d6: random code cleanups. - removed duplicate imports - whitespace fixes - removed unnecessary u"" prefixes - added missing r"" prefixes where required - added missing default values to DynamicForm() to prevent possible unassigned variable access - 33b37ec: updated settings.py for new deployments - updated Django documentation urls to point to the current version - renamed MIDDLEWARE_CLASSES to MIDDLEWARE, MIDDLEWARE_CLASSES is depreciated in Django >= 1.10 - whitespace and #noqa fixes - 92963a0: updated test_project, synced with a fresh deployment using Django 1.11.8 and updated settings.py so the tests environment matches a fresh deployment. --- There is one remaining warning for **Django 2.0** support in urls.py ([example](https://github.com/modoboa/modoboa/blob/master/modoboa/urls.py#L28)): `RemovedInDjango20Warning: Specifying a namespace in django.conf.urls.include() without providing an app_name is deprecated. Set the app_name attribute in the included module, or pass a 2-tuple containing the list of patterns and app_name instead.` The simple fix from the description is to add `app_name = "modoboa"` to urls.py however this then requires **every** (and there's a lot of them) `reverse("<url>")` or `reverse("<namespace>:<url>")` to be prefixed with `<app_name>`. The documentation is very thin for this feature so I'm not sure what's the best solution, it's not a real issue until you upgrade to Django 2.0. --- Extension PRs - modoboa/modoboa-amavis#81 - modoboa/modoboa-contacts#11 - modoboa/modoboa-dmarc#28 - modoboa/modoboa-imap-migration#29 - modoboa/modoboa-pdfcredentials#25 - modoboa/modoboa-postfix-autoreply#52 - modoboa/modoboa-radicale#17 - modoboa/modoboa-sievefilters#25 - modoboa/modoboa-stats#36 - modoboa/modoboa-webmail#136 **When this is merged extensions will need their requirements.txt updated to point at this version as a minimum for modobo.** --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

kerem 2026-02-27 12:09:49 +03:00

• closed this issue
• added the
  pull-request
  label

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

master

fix/sievefilters-allow-email-in-rule-name

dependabot/npm_and_yarn/frontend/axios-1.15.0

translations_04c0b653215cb5fa48ab101eae1a1917_ja_JP

translations_5d93982e9fd6dab991db4faf93ce9ded_ja_JP

fix/login-issue-3995

fix/sievefilters-issues

add-vitepress-openapi

2974-dmarc-empty-email

2.3.x

updated-doc-2.3.0

feature/OIDC

delete-all-alarms

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_af_ZA

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_ar

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_ca

1.x

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_sk

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_tr

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_es_ES

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_uk

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_zh_CN

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_de_DE

translations_modoboa-admin-locale-en-lc-messages-djangojs-po--master_da_DK

1.8.x

1.7.x

1.6.x

1.4.x

1.3.x

1.2.x

2.8.2

2.8.1

2.8.0

2.7.2

2.7.1

2.7.0

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6.0

2.5.1

2.5.0

2.4.11

2.4.10

2.4.9

2.4.8

2.4.7

2.4.6

2.4.5

2.4.4

2.4.3

2.4.2

2.4.1

2.4.0

2.3.6

2.3.5

2.3.4

2.3.3

2.3.2

2.3.1

2.3.0

2.3.0-beta.4

2.3.0-beta.3

2.3.0-beta.2

2.3.0-beta.1

2.2.4

2.2.3

2.2.2

2.2.1

2.2.0

2.1.2

2.1.1

2.1.0

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

2.0.0-beta.3

2.0.0-beta.2

2.0.0-beta.1

1.17.0

1.16.1

1.16.0

1.15.0

1.14.0

1.13.1

1.13.0

1.12.2

1.12.1

1.12.0

1.11.1

1.11.0

1.10.7

1.10.6

1.10.5

1.10.4

1.10.3

1.10.2

1.10.1

1.10.0

1.9.1

1.9.0

1.8.3

1.8.2

1.8.1

1.8.0

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.3

1.6.2

1.6.1

1.6.0

1.5.3

1.5.2

1.5.1

1.5.0

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.5

1.3.4

1.2.2

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.2.0-rc2

1.2.0-rc1

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.1

1.0.0

0.9.5

0.9.4

0.9.3

0.9.2

0.9.1

0.9

0.8.8

0.8.7

0.8.6.1

0.8.6

0.8.5

0.8.4

0.8.3

0.8.3-rc1

0.8.2

0.8.1

0.8

0.8-rc2

0.8-rc1

0.7.2

0.7.1

0.7

0.6.1

0.6

0.5

0.3

0.2

0.1

Labels

Clear labels   

bug

  

bug

  

dependencies

  

design

  

documentation

  

duplicate

  

enhancement

  

enhancement

  

enhancement

  

feedback-needed

  

help-needed

  

help-needed

  

installer

  

invalid

  

looking-for-sponsors

  

modoboa-contacts

  

new-ui

  

new-ui

  

pr

  

pull-request

Mirrored from GitHub Pull Request

  

pyconfr

  

python

  

question

  

security

  

stale

  

webmail

  

wontfix

No labels

bug

bug

dependencies

design

documentation

duplicate

enhancement

enhancement

enhancement

feedback-needed

help-needed

help-needed

installer

invalid

looking-for-sponsors

modoboa-contacts

new-ui

new-ui

pr

pull-request

pyconfr

python

question

security

stale

webmail

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/modoboa-modoboa#2194

No description provided.