[PR #1186] [MERGED] Fix redirect url #2151

New issue

Closed

opened 2026-02-27 12:09:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 12:09:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa/pull/1186
Author: @florealcab
Created: 7/14/2017
Status: ✅ Merged
Merged: 7/16/2017
Merged by: @tonioo

Base: master ← Head: master

📝 Commits (1)

d098a16 Fix redirect url

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 modoboa/core/views/base.py (+1 -1)

📄 Description

Description of the issue/feature this PR addresses:
When we logout, the new url has not the "next" get parameter. nextlocation is not None in this case, but "None" (the string).

Current behavior before PR:
So if we re-login, we are redirected to accounts/login/None, that does not exists (404).

Desired behavior after PR is merged:
I add ' != "None" ' to the conditions, so now the re-login works.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa/pull/1186 **Author:** [@florealcab](https://github.com/florealcab) **Created:** 7/14/2017 **Status:** ✅ Merged **Merged:** 7/16/2017 **Merged by:** [@tonioo](https://github.com/tonioo) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`d098a16`](https://github.com/modoboa/modoboa/commit/d098a166cbce026b5ae52a135699628028fbee41) Fix redirect url ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `modoboa/core/views/base.py` (+1 -1) </details> ### 📄 Description Description of the issue/feature this PR addresses: When we logout, the new url has not the "next" get parameter. nextlocation is not None in this case, but "None" (the string). Current behavior before PR: So if we re-login, we are redirected to accounts/login/None, that does not exists (404). Desired behavior after PR is merged: I add ' != "None" ' to the conditions, so now the re-login works. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>