[PR #1122] [MERGED] make modoboa-admin deploy work with python 3.4 #2128

New issue

Closed

opened 2026-02-27 12:09:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 12:09:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa/pull/1122
Author: @arthru
Created: 5/10/2017
Status: ✅ Merged
Merged: 5/12/2017
Merged by: @tonioo

Base: refacto/python3 ← Head: refacto/python3

📝 Commits (10+)

297a9ae make modoboa-admin deploy work with python 3.4
9a5c293 remove useless builtins imports
bcb3fe0 use pyldap in place of python-ldap in order to have python3 compatibility
19e0c7d add python 3.4 in tox conf
1ad280e make deploy command work in both python2 and python3
799e06b add dirs created while testing to gitignoe
615f73f unicode_literals everywhere and modoboa-admin deploy fixes
3114ae3 Merge remote-tracking branch 'upstream/refacto/python3' into refacto/python3
c97e5a7 fix tests for modoboa.core in python2
742d948 fix tests for modoboa.admin in python2

📊 Changes

190 files changed (+522 additions, -160 deletions)

View changed files

📝 .gitignore (+2 -0)
📝 .travis.yml (+1 -1)
📝 bin/modoboa-admin.py (+2 -0)
📝 ldap-requirements.txt (+0 -1)
📝 modoboa/__init__.py (+1 -0)
📝 modoboa/admin/__init__.py (+2 -0)
📝 modoboa/admin/api.py (+2 -0)
📝 modoboa/admin/app_settings.py (+4 -0)
📝 modoboa/admin/apps.py (+2 -0)
📝 modoboa/admin/constants.py (+2 -0)
📝 modoboa/admin/factories.py (+3 -0)
📝 modoboa/admin/forms/__init__.py (+2 -0)
📝 modoboa/admin/forms/account.py (+2 -0)
📝 modoboa/admin/forms/alias.py (+2 -0)
📝 modoboa/admin/forms/domain.py (+7 -3)
📝 modoboa/admin/forms/export.py (+4 -2)
📝 modoboa/admin/forms/forward.py (+2 -0)
📝 modoboa/admin/forms/import_.py (+3 -1)
📝 modoboa/admin/handlers.py (+2 -0)
📝 modoboa/admin/lib.py (+2 -0)

...and 80 more files

📄 Description

Description of the issue/feature this PR addresses:
The command modoboa-admin.py deploy --collectstatic --dburl default:postgres://localhost/modoboa_test --domain localhost --admin-username admin modoboa_test failed with a lot of errrors when launched with python 3.4. The PR aims to fix that.

Current behavior before PR:
Errors when launching ; return code != 0

Desired behavior after PR is merged:
No errors ; return code == 0

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa/pull/1122 **Author:** [@arthru](https://github.com/arthru) **Created:** 5/10/2017 **Status:** ✅ Merged **Merged:** 5/12/2017 **Merged by:** [@tonioo](https://github.com/tonioo) **Base:** `refacto/python3` ← **Head:** `refacto/python3` --- ### 📝 Commits (10+) - [`297a9ae`](https://github.com/modoboa/modoboa/commit/297a9aed94bea1ae6e38e304b74640380c553c82) make modoboa-admin deploy work with python 3.4 - [`9a5c293`](https://github.com/modoboa/modoboa/commit/9a5c293d520bb925f55d8edee479b7e2cb2ec542) remove useless builtins imports - [`bcb3fe0`](https://github.com/modoboa/modoboa/commit/bcb3fe0c1fe142cc98a9552e79d5209acb16cc21) use pyldap in place of python-ldap in order to have python3 compatibility - [`19e0c7d`](https://github.com/modoboa/modoboa/commit/19e0c7d0962f1f72030b2cec2a6ae4f1c6a2e418) add python 3.4 in tox conf - [`1ad280e`](https://github.com/modoboa/modoboa/commit/1ad280e2c9d0e243df515573bf3318b9a06923d0) make deploy command work in both python2 and python3 - [`799e06b`](https://github.com/modoboa/modoboa/commit/799e06bc2f486f8f45ae299eb5a4f131c58fb696) add dirs created while testing to gitignoe - [`615f73f`](https://github.com/modoboa/modoboa/commit/615f73f272363bc1e19ea8561215fa1a4b83bae7) unicode_literals everywhere and modoboa-admin deploy fixes - [`3114ae3`](https://github.com/modoboa/modoboa/commit/3114ae368bd8b28a38ddf262c144d471084199c3) Merge remote-tracking branch 'upstream/refacto/python3' into refacto/python3 - [`c97e5a7`](https://github.com/modoboa/modoboa/commit/c97e5a703d0162d7ab53e249b9148abe65083ec5) fix tests for modoboa.core in python2 - [`742d948`](https://github.com/modoboa/modoboa/commit/742d948e76c8128540d21b792b1c3b74fba7da4f) fix tests for modoboa.admin in python2 ### 📊 Changes **190 files changed** (+522 additions, -160 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -0) 📝 `.travis.yml` (+1 -1) 📝 `bin/modoboa-admin.py` (+2 -0) 📝 `ldap-requirements.txt` (+0 -1) 📝 `modoboa/__init__.py` (+1 -0) 📝 `modoboa/admin/__init__.py` (+2 -0) 📝 `modoboa/admin/api.py` (+2 -0) 📝 `modoboa/admin/app_settings.py` (+4 -0) 📝 `modoboa/admin/apps.py` (+2 -0) 📝 `modoboa/admin/constants.py` (+2 -0) 📝 `modoboa/admin/factories.py` (+3 -0) 📝 `modoboa/admin/forms/__init__.py` (+2 -0) 📝 `modoboa/admin/forms/account.py` (+2 -0) 📝 `modoboa/admin/forms/alias.py` (+2 -0) 📝 `modoboa/admin/forms/domain.py` (+7 -3) 📝 `modoboa/admin/forms/export.py` (+4 -2) 📝 `modoboa/admin/forms/forward.py` (+2 -0) 📝 `modoboa/admin/forms/import_.py` (+3 -1) 📝 `modoboa/admin/handlers.py` (+2 -0) 📝 `modoboa/admin/lib.py` (+2 -0) _...and 80 more files_ </details> ### 📄 Description Description of the issue/feature this PR addresses: The command `modoboa-admin.py deploy --collectstatic --dburl default:postgres://localhost/modoboa_test --domain localhost --admin-username admin modoboa_test` failed with a lot of errrors when launched with python 3.4. The PR aims to fix that. Current behavior before PR: Errors when launching ; return code != 0 Desired behavior after PR is merged: No errors ; return code == 0 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>