[PR #16] [MERGED] bugfix #490 and added possibility of silent installation using database-urls #1959

New issue

Closed

opened 2026-02-27 11:20:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 11:20:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/modoboa/modoboa/pull/16
Author: @simonkern
Created: 10/16/2013
Status: ✅ Merged
Merged: 11/2/2013
Merged by: @tonioo

Base: master ← Head: master

📝 Commits (5)

dc688ec fixed the path for core/commands/templates
d8f39f7 added possibility to supply database settings and domain via command line args
999a78b added silent installation / database_urls to the docs
9efd084 added preliminary test
17c198e fixed wrong driver for PostgreSQL in dovecot conf

📊 Changes

7 files changed (+143 additions, -37 deletions)

View changed files

📝 MANIFEST.in (+2 -1)
📝 doc/getting_started/install.rst (+26 -1)
📝 doc/integration/imap_and_smtp.rst (+7 -7)
📝 modoboa/core/commands/__init__.py (+1 -1)
📝 modoboa/core/commands/deploy.py (+73 -27)
📝 requirements.txt (+1 -0)
📝 tests/install_from_scratch.py (+33 -0)

📄 Description

Fix for #490
While trying to deploy modoboa, it throws an error due to a wrong path. This is most likely related to the following commits:

github.com/tonioo/modoboa@02b1388d79 and / or github.com/tonioo/modoboa@937e09c723

The new template path was also missing in the MANIFEST.in
IOError: [Errno 2] No such file or directory: '/Users/simme/.virtualenvs/test/lib/python2.7/site-packages/modoboa-1.0.1-py2.7.egg/modoboa/core/commands/commands/templates/settings.py.tpl'

Implementation of #489
In order to make the instalation using salt stack, modoboa-admin.py needs to have extra parameters for database configuration

If a users enters a nonsense url like "postgres://" it falls back to asking questions...

please see:
http://dev.modoboa.org/issues/490
and
http://dev.modoboa.org/issues/489

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/modoboa/modoboa/pull/16 **Author:** [@simonkern](https://github.com/simonkern) **Created:** 10/16/2013 **Status:** ✅ Merged **Merged:** 11/2/2013 **Merged by:** [@tonioo](https://github.com/tonioo) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`dc688ec`](https://github.com/modoboa/modoboa/commit/dc688ecc39d1e0f31b96e1fbd152fb3b4b2130b6) fixed the path for core/commands/templates - [`d8f39f7`](https://github.com/modoboa/modoboa/commit/d8f39f700b00200a171c244c540a494c21be5499) added possibility to supply database settings and domain via command line args - [`999a78b`](https://github.com/modoboa/modoboa/commit/999a78bf2e89f6cbd4ef442aaee0fea9af03d2a1) added silent installation / database_urls to the docs - [`9efd084`](https://github.com/modoboa/modoboa/commit/9efd08438d13c0c3eb914aa790606d75580271dd) added preliminary test - [`17c198e`](https://github.com/modoboa/modoboa/commit/17c198e26f9ce9e2843b108f640f3ae8f06fe2ab) fixed wrong driver for PostgreSQL in dovecot conf ### 📊 Changes **7 files changed** (+143 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `MANIFEST.in` (+2 -1) 📝 `doc/getting_started/install.rst` (+26 -1) 📝 `doc/integration/imap_and_smtp.rst` (+7 -7) 📝 `modoboa/core/commands/__init__.py` (+1 -1) 📝 `modoboa/core/commands/deploy.py` (+73 -27) 📝 `requirements.txt` (+1 -0) 📝 `tests/install_from_scratch.py` (+33 -0) </details> ### 📄 Description **Fix for #490** While trying to deploy modoboa, it throws an error due to a wrong path. This is most likely related to the following commits: https://github.com/tonioo/modoboa/commit/02b1388d795d2b62360b3acaf1ae3d165a9c6514 and / or https://github.com/tonioo/modoboa/commit/937e09c7235f64f041f595b17687193c02782493 The new template path was also missing in the MANIFEST.in `IOError: [Errno 2] No such file or directory: '/Users/simme/.virtualenvs/test/lib/python2.7/site-packages/modoboa-1.0.1-py2.7.egg/modoboa/core/commands/commands/templates/settings.py.tpl'` **Implementation of #489** In order to make the instalation using salt stack, modoboa-admin.py needs to have extra parameters for database configuration If a users enters a nonsense url like "postgres://" it falls back to asking questions... **please see:** http://dev.modoboa.org/issues/490 and http://dev.modoboa.org/issues/489 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>