mirror of
https://github.com/modoboa/modoboa.git
synced 2026-04-25 08:56:02 +03:00
[GH-ISSUE #2719] Accept-Language header takes precedence over profile language setting #1685
Labels
No labels
bug
bug
dependencies
design
documentation
duplicate
enhancement
enhancement
enhancement
feedback-needed
help-needed
help-needed
installer
invalid
looking-for-sponsors
modoboa-contacts
new-ui
new-ui
pr
pull-request
pyconfr
python
question
security
stale
webmail
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/modoboa-modoboa#1685
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @PatTheMav on GitHub (Dec 27, 2022).
Original GitHub issue: https://github.com/modoboa/modoboa/issues/2719
After tinkering with the request headers for a bit, I've found that the
Accept-Language(if it contains a supported and available translated language) will take precedence over the language actually setup in the modo boa profile.Removing the header will revert this behaviour, which seems to have been introduced by the v2.0.0 interface (which also has the same issue).
Discussed in https://github.com/modoboa/modoboa/discussions/2519
Originally posted by PatTheMav May 20, 2022
Ever since I upgraded to v2.0.0 I got mixed translations in the interface.
LANGUAGE_CODEis set toen-usin the settings file, the given profile is set to use "english".Up to and including v1.1.7 this worked without issue, but with v2.0.0 I now got stray German labels and menu items in the legacy UI as well as the v2 admin interface. In the v2 admin interface I also get a lots of
Untranslated en key foundwarnings in the console.Is there an implicit localisation going on based on languages passed by browser headers (which will have German preferred over English as my OS is set to German) and my account settings not taking precedence?
@moweerkat commented on GitHub (Feb 17, 2023):
https://github.com/modoboa/modoboa/pull/2788