mirror of
https://github.com/modoboa/modoboa.git
synced 2026-04-25 08:56:02 +03:00
[GH-ISSUE #2708] modoboa-admin.py deploy trips over itself (fails catastrophically trying to uninstall version of django_filter not installed) #1681
Labels
No labels
bug
bug
dependencies
design
documentation
duplicate
enhancement
enhancement
enhancement
feedback-needed
help-needed
help-needed
installer
invalid
looking-for-sponsors
modoboa-contacts
new-ui
new-ui
pr
pull-request
pyconfr
python
question
security
stale
webmail
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/modoboa-modoboa#1681
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bernd-wechner on GitHub (Dec 11, 2022).
Original GitHub issue: https://github.com/modoboa/modoboa/issues/2708
Impacted versions
Steps to reproduce
Follow the manual installation procedure landing at:
https://modoboa.readthedocs.io/en/latest/manual_installation/modoboa.html#deploy-an-instance
Current behavior
pip install wheel modoboa psycopg2modoboa-admin.py deploy mysite --collectstatic --domain my.domain --dburl default:postgres://modoboa:password@[localhost]/modoboa --extensions allOutput is:
Do diagnose:
Note:
modoboa-admin.py deploy"Found existing installation: django-filter 22.1" and tried to unsintall it and unsurprisingly bombed because it isn't installed, 21.1 is and the file/data/venv/modoboa/lib/python3.10/site-packages/django_filter-22.1.dist-info/METADATA' does indeed not exist, but this one does:/data/venv/modoboa/lib/python3.10/site-packages/django_filter-2`.1.dist-info/METADATA'Expected behavior
That modoboa-admin.py doesn't see django-filter 22.1 installed when it isn't and does see django-filter 21.1 when it is. To be honest that's one creative bug, I have no idea how it can happen. Will in due course drill into the scripts at see (assuming it reproduces when I empty the venv, and start from start again) but for now, figured it best to report.
@bernd-wechner commented on GitHub (Dec 11, 2022):
Update: on a clean venv,
pip install wheel modoboa psycopg2followed by:We see modoboa installs django_filter 22.1 by default.
Trying the deploy again the issue reproduces. It seems in the deploy, there is first:
followed later by:
followed by the crash:
@bernd-wechner commented on GitHub (Dec 11, 2022):
Figuring it was a bug in an extension, dropped
--extensions alland it completed without crash. Confirming it's in one of the extensions.@tonioo commented on GitHub (Dec 14, 2022):
@bernd-wechner Have you tried to upgrade pip ?
@bernd-wechner commented on GitHub (Dec 14, 2022):
Always use the latest version yes. Can double check but reflexively update pip when it asks me to, which it does with tedious frequency.
@bernd-wechner commented on GitHub (Dec 21, 2022):
$ pip --version
pip 22.0.2 from /data/venv/modoboa/lib/python3.10/site-packages/pip (python 3.10)
@tonioo commented on GitHub (Feb 15, 2023):
I think this issue should be solved now. It was due to a dependency conflict between calendar and contacts plugins.