starred/modoboa-modoboa

Fork 0

mirror of https://github.com/modoboa/modoboa.git synced 2026-04-25 08:56:02 +03:00

[GH-ISSUE #2567] hard coded path won't work if you use a path prefix #1639

New issue

Closed

opened 2026-02-27 11:18:17 +03:00 by kerem · 4 comments

kerem commented

2026-02-27 11:18:17 +03:00

Owner

Originally created by @gawel on GitHub (Jul 20, 2022).
Original GitHub issue: https://github.com/modoboa/modoboa/issues/2567

Impacted versions

OS Type: Debian
OS Version: Bullseye
Database Type: MySQL
Database version: X.y
Modoboa: 2.0.1
installer used: No
Webserver: Apache

Steps to reproduce

Create a urls.py file and use it in your settings:

from django.conf.urls import include, url

urlpatterns = [
    url(r'^manager/', include('modoboa.urls')),
]

Current behavior

There is some hard coded links in the js files. At least for the 2FA auth: github.com/modoboa/modoboa@fda59b51e1/modoboa/static/js/twocols_nav.js (L180)

But the real url is /manager/api/... so the ajax request fail with a 404

Same problem with the new vuejs UI. Everything is expected to be at /new-admin/ but we need /manager/new-admin. I guess this one can be fixed with sed

Expected behavior

Api calls should work even if we use a prefix

A solution is to define a js variable with the correct prefix. Something like:

window.API_ROOT = "{% url api_root %}"

And use this var in the js files.

Originally created by @gawel on GitHub (Jul 20, 2022). Original GitHub issue: https://github.com/modoboa/modoboa/issues/2567 # Impacted versions * OS Type: Debian * OS Version: Bullseye * Database Type: MySQL * Database version: X.y * Modoboa: 2.0.1 * installer used: No * Webserver: Apache # Steps to reproduce Create a urls.py file and use it in your settings: ``` from django.conf.urls import include, url urlpatterns = [ url(r'^manager/', include('modoboa.urls')), ] ``` # Current behavior There is some hard coded links in the js files. At least for the 2FA auth: https://github.com/modoboa/modoboa/blob/fda59b51e1ef7f57f3601015dcdc2693f7f7efe8/modoboa/static/js/twocols_nav.js#L180 But the real url is `/manager/api/...` so the ajax request fail with a 404 Same problem with the new vuejs UI. Everything is expected to be at `/new-admin/` but we need `/manager/new-admin`. I guess this one can be fixed with sed # Expected behavior Api calls should work even if we use a prefix A solution is to define a js variable with the correct prefix. Something like: ``` window.API_ROOT = "{% url api_root %}" ``` And use this var in the js files.

kerem

2026-02-27 11:18:17 +03:00

closed this issue
added the
bug
label

kerem commented

2026-02-27 11:18:18 +03:00

Author

Owner

@ksaadDE commented on GitHub (Jul 25, 2022):

Could you create a patch + PR for this?

To my understanding of reading it for a few seconds, it might be a variable change in the files, since it is hardcoded right?

@ksaadDE commented on GitHub (Jul 25, 2022): Could you create a patch + PR for this? To my understanding of reading it for a few seconds, it might be a variable change in the files, since it is hardcoded right?

kerem commented

2026-02-27 11:18:18 +03:00

Author

Owner

@gawel commented on GitHub (Aug 18, 2022):

PR done for the tfa stuff. Looks likes a postgres test is failing because of... mysql. Not sure how to fix that

@gawel commented on GitHub (Aug 18, 2022): PR done for the tfa stuff. Looks likes a postgres test is failing because of... mysql. Not sure how to fix that

kerem commented

2026-02-27 11:18:18 +03:00

Author

Owner

@ksaadDE commented on GitHub (Aug 24, 2022):

PR done for the tfa stuff. Looks likes a postgres test is failing because of... mysql. Not sure how to fix that

@tonioo

@ksaadDE commented on GitHub (Aug 24, 2022): > PR done for the tfa stuff. Looks likes a postgres test is failing because of... mysql. Not sure how to fix that @tonioo

kerem commented

2026-02-27 11:18:18 +03:00

Author

Owner

@tonioo commented on GitHub (Sep 5, 2022):

For the record, it's not possible to conditionally start services with GHA (see https://github.com/actions/runner/issues/822)

@tonioo commented on GitHub (Sep 5, 2022): For the record, it's not possible to conditionally start services with GHA (see https://github.com/actions/runner/issues/822)