mirror of
https://github.com/modoboa/modoboa.git
synced 2026-04-25 00:46:03 +03:00
[GH-ISSUE #2974] Failure to process DMARC reports with empty email in report_metadata #1638
Labels
No labels
bug
bug
dependencies
design
documentation
duplicate
enhancement
enhancement
enhancement
feedback-needed
help-needed
help-needed
installer
invalid
looking-for-sponsors
modoboa-contacts
new-ui
new-ui
pr
pull-request
pyconfr
python
question
security
stale
webmail
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/modoboa-modoboa#1638
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tschuettler on GitHub (Jul 18, 2022).
Original GitHub issue: https://github.com/modoboa/modoboa/issues/2974
The current model understandably can't handle DMARC reports where the email is empty since the email is supposed to be not null and unique and is used to retrieve the reporter id:
github.com/modoboa/modoboa-dmarc@3e21a93de4/modoboa_dmarc/lib.py (L96)While perhpaps not intended by the specification, the xml-schema of that part of the report is valid according to https://dmarc.org/dmarc-xml/0.1/rua.xsd as far as I understand that. It requires a element type of string, but does not require it to have a length > 0 or even be a proper email address.
For completeness here is an excerpt of the traceback:
I tried to contact synaq.com some time ago, but have not seen any reaction from them yet. In contrast to earlier DMARC reports they even changed their report emails not to have a from email address or even a return-path, most likely to stop getting bounced dmarc reports. In our instance I have never observed this issue by anyone else but synaq.com.
Perhaps we can relax those requirements and check for the organisation name if there is no email address or we could create a catch all organization were all reports without an email would show up.
@kryskool commented on GitHub (Feb 5, 2026):
In this case we can
@tonioo what do you think ?