[GH-ISSUE #172] Import problems #155

Closed
opened 2026-02-27 11:10:22 +03:00 by kerem · 5 comments
Owner

Originally created by @tonioo on GitHub (Dec 4, 2013).
Original GitHub issue: https://github.com/modoboa/modoboa/issues/172

Originally assigned to: @tonioo on GitHub.

Originally created by Alain Perry on 2011-08-30T14:52:03Z

Some imports don't work out of the box in 0.8.6. I was able to correct them using the attached patch.

Originally created by @tonioo on GitHub (Dec 4, 2013). Original GitHub issue: https://github.com/modoboa/modoboa/issues/172 Originally assigned to: @tonioo on GitHub. **Originally created by Alain Perry on 2011-08-30T14:52:03Z** Some imports don't work out of the box in 0.8.6. I was able to correct them using the attached patch.
kerem 2026-02-27 11:10:22 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@tonioo commented on GitHub (Dec 4, 2013):

Posted by Antoine Nguyen on 2011-08-30T14:56:08Z

I don't see any attached patch, is that normal ? ;-)

<!-- gh-comment-id:29813931 --> @tonioo commented on GitHub (Dec 4, 2013): **Posted by Antoine Nguyen on 2011-08-30T14:56:08Z** I don't see any attached patch, is that normal ? ;-)
Author
Owner

@tonioo commented on GitHub (Dec 4, 2013):

Posted by Alain Perry on 2011-08-30T15:01:16Z

No it isn't: Trac won't let me attach a file to the ticket. I guess it is a permission problem.

Anyways, here's the proposed patch pasted inline:


diff -r 02ea815dc1c4 admin/templatetags/admin_extras.py
--- a/admin/templatetags/admin_extras.py    Mon Aug 29 13:45:34 2011 +0200
+++ b/admin/templatetags/admin_extras.py    Tue Aug 30 16:50:17 2011 +0200
@@ -188,7 +188,7 @@
 
 @register.simple_tag
 def mbalias_actions(user, aliasid):
-    from admin.models import Alias
+    from modoboa.admin.models import Alias
 
     alias = Alias.objects.get(pk=aliasid)
     if alias.ui_disabled(user):
diff -r 02ea815dc1c4 admin/views.py
--- a/admin/views.py    Mon Aug 29 13:45:34 2011 +0200
+++ b/admin/views.py    Tue Aug 30 16:50:17 2011 +0200
@@ -15,8 +15,8 @@
 from lib import *
 from modoboa import admin, userprefs
 from models import *
-from admin.permissions import *
-from admin.tables import *
+from modoboa.admin.permissions import *
+from modoboa.admin.tables import *
 from modoboa.lib import events, parameters
 from modoboa.auth.lib import crypt_password
 from modoboa.lib.webutils \
<!-- gh-comment-id:29813932 --> @tonioo commented on GitHub (Dec 4, 2013): **Posted by Alain Perry on 2011-08-30T15:01:16Z** No it isn't: Trac won't let me attach a file to the ticket. I guess it is a permission problem. Anyways, here's the proposed patch pasted inline: <pre> <code class="diff"> diff -r 02ea815dc1c4 admin/templatetags/admin_extras.py --- a/admin/templatetags/admin_extras.py Mon Aug 29 13:45:34 2011 +0200 +++ b/admin/templatetags/admin_extras.py Tue Aug 30 16:50:17 2011 +0200 @@ -188,7 +188,7 @@ @register.simple_tag def mbalias_actions(user, aliasid): - from admin.models import Alias + from modoboa.admin.models import Alias alias = Alias.objects.get(pk=aliasid) if alias.ui_disabled(user): diff -r 02ea815dc1c4 admin/views.py --- a/admin/views.py Mon Aug 29 13:45:34 2011 +0200 +++ b/admin/views.py Tue Aug 30 16:50:17 2011 +0200 @@ -15,8 +15,8 @@ from lib import * from modoboa import admin, userprefs from models import * -from admin.permissions import * -from admin.tables import * +from modoboa.admin.permissions import * +from modoboa.admin.tables import * from modoboa.lib import events, parameters from modoboa.auth.lib import crypt_password from modoboa.lib.webutils \ </code></pre>
Author
Owner

@tonioo commented on GitHub (Dec 4, 2013):

Posted by Antoine Nguyen on 2011-08-30T15:04:34Z

You're right. It should be ok now.

<!-- gh-comment-id:29813933 --> @tonioo commented on GitHub (Dec 4, 2013): **Posted by Antoine Nguyen on 2011-08-30T15:04:34Z** You're right. It should be ok now.
Author
Owner

@tonioo commented on GitHub (Dec 4, 2013):

Posted by Antoine Nguyen on 2011-08-30T17:13:20Z

Here is a little patch for Django 1.2 users. It will be officially included into the next release.

<!-- gh-comment-id:29813934 --> @tonioo commented on GitHub (Dec 4, 2013): **Posted by Antoine Nguyen on 2011-08-30T17:13:20Z** Here is a little patch for Django 1.2 users. It will be officially included into the next release.
Author
Owner

@tonioo commented on GitHub (Dec 4, 2013):

Posted by Redmine Admin on 2011-08-30T17:14:52Z

In [8fc622f3b87532f8c83aba9ebc243ef30f2ff49b]:

#!CommitTicketReference repository="" revision="8fc622f3b87532f8c83aba9ebc243ef30f2ff49b"
* Django 1.2 compatibility for LDAP authentication
* Fixed bad import statements
fixed #159
<!-- gh-comment-id:29813937 --> @tonioo commented on GitHub (Dec 4, 2013): **Posted by Redmine Admin on 2011-08-30T17:14:52Z** In [8fc622f3b87532f8c83aba9ebc243ef30f2ff49b]: <pre> #!CommitTicketReference repository="" revision="8fc622f3b87532f8c83aba9ebc243ef30f2ff49b" * Django 1.2 compatibility for LDAP authentication * Fixed bad import statements fixed #159 </pre>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/modoboa-modoboa#155
No description provided.