mirror of
https://github.com/modoboa/modoboa.git
synced 2026-04-26 09:26:00 +03:00
[GH-ISSUE #2038] Improve DNS checks to allow DNS servers not working temporary #1511
Labels
No labels
bug
bug
dependencies
design
documentation
duplicate
enhancement
enhancement
enhancement
feedback-needed
help-needed
help-needed
installer
invalid
looking-for-sponsors
modoboa-contacts
new-ui
new-ui
pr
pull-request
pyconfr
python
question
security
stale
webmail
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/modoboa-modoboa#1511
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MrGeneration on GitHub (Oct 20, 2020).
Original GitHub issue: https://github.com/modoboa/modoboa/issues/2038
Impacted versions
Steps to reproduce
Force your DNS resolver to be unavailable for a moment (for whatever reason).
Current behavior
Modoboa regulary tries to resolve all relevant DNS entries for configured domains if enabled.
It will, in case e.g. a MX record no longer can be found, send a mail to the domain owner to inform about this issue.
Expected behavior
If Modoboa is unable to query the DNS server for a moment it should temporarily ignore this issue (maybe change the record from green to yellow to indicate a temporary issue) and maybe inform the instance owner. The logfile states a resolution timeout:
Issue #1023 technically would be very useful in such an situation as well.
TL;DR
If DNS resolution fails inform instance owner and do not thread this situation as non existent DNS record.
@tonioo commented on GitHub (Oct 21, 2020):
@MrGeneration Actually you can already disable tests for a specific domain. Is it not enough?
@MrGeneration commented on GitHub (Oct 21, 2020):
While this is true, this was temporary affecting 50% of my domains due a temporary route issue to the affected DNS servers.
So sadly, no this wouldn't be an option.
Personally I think that the DNS check should be robust enough to know the difference between a simple timeout or
NXDOMAIN. Because this would also allow you to throw different errors.I really love the domain check functionality and am using it where ever possible.
@stale[bot] commented on GitHub (Dec 22, 2020):
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@MrGeneration commented on GitHub (Dec 23, 2020):
I still believe that modoboa should handle not reachable DNS servers better. :x
@stale[bot] commented on GitHub (Feb 21, 2021):
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.