mirror of
https://github.com/modoboa/modoboa.git
synced 2026-04-26 01:16:01 +03:00
[GH-ISSUE #1780] "Exit on StopIteration" with Python 3.7 #1404
Labels
No labels
bug
bug
dependencies
design
documentation
duplicate
enhancement
enhancement
enhancement
feedback-needed
help-needed
help-needed
installer
invalid
looking-for-sponsors
modoboa-contacts
new-ui
new-ui
pr
pull-request
pyconfr
python
question
security
stale
webmail
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/modoboa-modoboa#1404
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @lefta on GitHub (Oct 4, 2019).
Original GitHub issue: https://github.com/modoboa/modoboa/issues/1780
Impacted versions
Likely all, tested on 1.14.0 / webmail 1.5.0. Installer / web server are not relevant here.
Steps to reproduce
Open a mail containing an attachment when running with python 3.7, a 500 error will be returned (after several seconds).
Current behavior
Crash with exception "Exit on StopIteration".
Expected behavior
Mmmh... No crash ?
More details
Python 3.7 implements PEP-479 which breaks LEPL, dependency of rfc6266.
However, it seems that neither LEPL nor rfc6266 are maintained anymore. I wrote a drop in replacement for rfc6266 to get it working, however I can't tell about compatibility, security, conformance or stability of it. At least it allows to open mails with attachments and can be used as a base for fixing this issue.
@tonioo commented on GitHub (Oct 11, 2019):
@lefta Thanks for the report. Could you please move this issue to the modoboa-webmail repository?
@lefta commented on GitHub (Oct 11, 2019):
I forgot to make it explicit in my original report, but I filled this issue against Modoboa itself because rfc6266 is a dependency of it, not of the webmail. I had problems only with the webmail, but any Modoboa part decoding the
Content-Dispositionheader with this package will be impacted (and now that it is fixed on my side, I can't test other areas anymore).This being said, should I still move it ?
@tonioo commented on GitHub (Oct 13, 2019):
@lefta Ok, so it's the right place.
@rvicentiu commented on GitHub (Mar 2, 2020):
Any updates on this bug?
Ran into the same issue with a fresh modoboa install on debian 10.
@lefta Thanks for the patch, it works :)
@tonioo commented on GitHub (Mar 3, 2020):
I've finally removed the dependancy to rfc6266 (see
github.com/modoboa/modoboa-webmail@2dc6c2fbab).