mirror of
https://github.com/modoboa/modoboa.git
synced 2026-04-26 01:16:01 +03:00
[GH-ISSUE #1673] argon2 support #1315
Labels
No labels
bug
bug
dependencies
design
documentation
duplicate
enhancement
enhancement
enhancement
feedback-needed
help-needed
help-needed
installer
invalid
looking-for-sponsors
modoboa-contacts
new-ui
new-ui
pr
pull-request
pyconfr
python
question
security
stale
webmail
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/modoboa-modoboa#1315
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Arvedui on GitHub (Feb 11, 2019).
Original GitHub issue: https://github.com/modoboa/modoboa/issues/1673
From the django docs:
As indicated django supports argon2 and dovecot does as well.
Unfortunately passlib only supports argon2i, not argon2id. The later seems to be the better one for general use. And since passlib upstream seems to have died in 2017 I would not bet on them implementing it anytime soon. There is even a working patch which was completely ignored.
However argon2-cffi, which is the preferred argon2 backend of passlib, does support argon2id and defaults to it. It is quite high level as well so it would be pretty easy to implement.
I could do it myself if there is no objection against using argon2-cffi.
@tonioo commented on GitHub (Feb 25, 2019):
@Arvedui That's a good idea and there is no objection against using argon2-cffi ;)
@Arvedui commented on GitHub (Mar 1, 2019):
Great!
One thing though:
argon has 3 parameters
The libraries defaults are sensible as far as I can tell, but they should be tweak able.
Would it be acceptable if that could only be done in settings.py?
@tonioo commented on GitHub (Mar 1, 2019):
@Arvedui I think so, we just need to provide acceptable default values.