[GH-ISSUE #1475] [dkim] changing the key size does nothing #1159

Closed
opened 2026-02-27 11:15:37 +03:00 by kerem · 4 comments
Owner

Originally created by @Toniob on GitHub (Apr 20, 2018).
Original GitHub issue: https://github.com/modoboa/modoboa/issues/1475

Steps to reproduce

Enable dkim for a domain with a specific keysize. Wait for the key to be generated and saved on disk. Edit your domain and change the size of the key.

Current behavior

The key in the database and the saved one doesn't change.

Expected behavior

Check if the size is changed and force the creation of a new key if that's the case.

Originally created by @Toniob on GitHub (Apr 20, 2018). Original GitHub issue: https://github.com/modoboa/modoboa/issues/1475 # Steps to reproduce Enable dkim for a domain with a specific keysize. Wait for the key to be generated and saved on disk. Edit your domain and change the size of the key. # Current behavior The key in the database and the saved one doesn't change. # Expected behavior Check if the size is changed and force the creation of a new key if that's the case.
kerem 2026-02-27 11:15:37 +03:00
Author
Owner

@tonioo commented on GitHub (Apr 27, 2018):

@Toniob Is it safe to recreate the key? I guess some people would forget to update their DNS records after...

<!-- gh-comment-id:384881405 --> @tonioo commented on GitHub (Apr 27, 2018): @Toniob Is it safe to recreate the key? I guess some people would forget to update their DNS records after...
Author
Owner

@carbans commented on GitHub (May 4, 2018):

I think that if you specify in the interface what could be the record that you add in the DNS, people would take into account that you have to change it in the DNS.
In other mail system I have seen DKIM record in the webpanel, and I only haved have to copy and add to my DNS server, and this remember that I will have update my DNS.

Could something similar solve the problem?

<!-- gh-comment-id:386528809 --> @carbans commented on GitHub (May 4, 2018): I think that if you specify in the interface what could be the record that you add in the DNS, people would take into account that you have to change it in the DNS. In other mail system I have seen DKIM record in the webpanel, and I only haved have to copy and add to my DNS server, and this remember that I will have update my DNS. Could something similar solve the problem?
Author
Owner

@Toniob commented on GitHub (May 4, 2018):

Another way is to add another check, like the mx and dnsbl ones. We just have to make a dns request to check that the TXT record is the good one. If not, show it in the user interface, and maybe send an email.

<!-- gh-comment-id:386539245 --> @Toniob commented on GitHub (May 4, 2018): Another way is to add another check, like the mx and dnsbl ones. We just have to make a dns request to check that the TXT record is the good one. If not, show it in the user interface, and maybe send an email.
Author
Owner

@carbans commented on GitHub (May 4, 2018):

I think this is a good solution, because you have the certainty that it's works

<!-- gh-comment-id:386567977 --> @carbans commented on GitHub (May 4, 2018): I think this is a good solution, because you have the certainty that it's works
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/modoboa-modoboa#1159
No description provided.