mirror of
https://github.com/modoboa/modoboa.git
synced 2026-04-26 17:36:01 +03:00
[GH-ISSUE #1475] [dkim] changing the key size does nothing #1159
Labels
No labels
bug
bug
dependencies
design
documentation
duplicate
enhancement
enhancement
enhancement
feedback-needed
help-needed
help-needed
installer
invalid
looking-for-sponsors
modoboa-contacts
new-ui
new-ui
pr
pull-request
pyconfr
python
question
security
stale
webmail
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/modoboa-modoboa#1159
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Toniob on GitHub (Apr 20, 2018).
Original GitHub issue: https://github.com/modoboa/modoboa/issues/1475
Steps to reproduce
Enable dkim for a domain with a specific keysize. Wait for the key to be generated and saved on disk. Edit your domain and change the size of the key.
Current behavior
The key in the database and the saved one doesn't change.
Expected behavior
Check if the size is changed and force the creation of a new key if that's the case.
@tonioo commented on GitHub (Apr 27, 2018):
@Toniob Is it safe to recreate the key? I guess some people would forget to update their DNS records after...
@carbans commented on GitHub (May 4, 2018):
I think that if you specify in the interface what could be the record that you add in the DNS, people would take into account that you have to change it in the DNS.
In other mail system I have seen DKIM record in the webpanel, and I only haved have to copy and add to my DNS server, and this remember that I will have update my DNS.
Could something similar solve the problem?
@Toniob commented on GitHub (May 4, 2018):
Another way is to add another check, like the mx and dnsbl ones. We just have to make a dns request to check that the TXT record is the good one. If not, show it in the user interface, and maybe send an email.
@carbans commented on GitHub (May 4, 2018):
I think this is a good solution, because you have the certainty that it's works