[PR #249] [CLOSED] Add camera man video effect with quick button toggle #248

Closed
opened 2026-03-02 04:00:54 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/eerimoq/moblin/pull/249
Author: @Copilot
Created: 2/21/2026
Status: Closed

Base: mainHead: copilot/add-camera-movement-effect


📝 Commits (3)

  • 0ceefaa Initial plan
  • b6a900b Add camera man video effect with quick button toggle
  • 155e863 Add cameraMan case to SettingsControllerFunction enum

📊 Changes

8 files changed (+72 additions, -0 deletions)

View changed files

📝 Moblin/Various/Model/Model.swift (+1 -0)
📝 Moblin/Various/Model/ModelGameController.swift (+4 -0)
📝 Moblin/Various/Model/ModelScene.swift (+4 -0)
📝 Moblin/Various/Settings/Settings.swift (+6 -0)
📝 Moblin/Various/Settings/SettingsGameController.swift (+5 -0)
📝 Moblin/Various/Settings/SettingsQuickButtons.swift (+1 -0)
Moblin/VideoEffects/CameraManEffect.swift (+39 -0)
📝 Moblin/View/ControlBar/QuickButtonsView.swift (+12 -0)

📄 Description

  • Create CameraManEffect.swift video effect that simulates camera operator movement
  • Add cameraMan case to SettingsQuickButtonType enum
  • Add cameraMan case to SettingsControllerFunction enum (with toString() and section())
  • Add cameraManEffect property to Model class
  • Initialize effect in createGlobalVideoEffects in ModelScene.swift
  • Register effect in registerGlobalVideoEffects in ModelScene.swift
  • Add quick button definition in Settings.swift
  • Add action handler in QuickButtonsView.swift
  • Add switch case rendering in QuickButtonsView.swift
  • Add game controller case in ModelGameController.swift
  • Run code review and security checks

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/eerimoq/moblin/pull/249 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 2/21/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `copilot/add-camera-movement-effect` --- ### 📝 Commits (3) - [`0ceefaa`](https://github.com/eerimoq/moblin/commit/0ceefaa62cd12259258febe3d21732f979db1c06) Initial plan - [`b6a900b`](https://github.com/eerimoq/moblin/commit/b6a900bf4f470f1fd0777cda60ac60e3f05972e3) Add camera man video effect with quick button toggle - [`155e863`](https://github.com/eerimoq/moblin/commit/155e8631b8534fe68d64867c63f912b6d8cd018d) Add cameraMan case to SettingsControllerFunction enum ### 📊 Changes **8 files changed** (+72 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Moblin/Various/Model/Model.swift` (+1 -0) 📝 `Moblin/Various/Model/ModelGameController.swift` (+4 -0) 📝 `Moblin/Various/Model/ModelScene.swift` (+4 -0) 📝 `Moblin/Various/Settings/Settings.swift` (+6 -0) 📝 `Moblin/Various/Settings/SettingsGameController.swift` (+5 -0) 📝 `Moblin/Various/Settings/SettingsQuickButtons.swift` (+1 -0) ➕ `Moblin/VideoEffects/CameraManEffect.swift` (+39 -0) 📝 `Moblin/View/ControlBar/QuickButtonsView.swift` (+12 -0) </details> ### 📄 Description - [x] Create `CameraManEffect.swift` video effect that simulates camera operator movement - [x] Add `cameraMan` case to `SettingsQuickButtonType` enum - [x] Add `cameraMan` case to `SettingsControllerFunction` enum (with `toString()` and `section()`) - [x] Add `cameraManEffect` property to Model class - [x] Initialize effect in `createGlobalVideoEffects` in ModelScene.swift - [x] Register effect in `registerGlobalVideoEffects` in ModelScene.swift - [x] Add quick button definition in Settings.swift - [x] Add action handler in QuickButtonsView.swift - [x] Add switch case rendering in QuickButtonsView.swift - [x] Add game controller case in ModelGameController.swift - [x] Run code review and security checks <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 04:00:54 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/moblin#248
No description provided.