[PR #234] [CLOSED] Refactor WhipStream: ICE gathering, cleanup, and RTP improvements #235

Closed
opened 2026-03-02 04:00:52 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/eerimoq/moblin/pull/234
Author: @Kn0ax
Created: 2/12/2026
Status: Closed

Base: mainHead: whipfixes


📝 Commits (1)

  • 19d7a82 Refactor WhipStream: ICE gathering, cleanup, and RTP improvements

📊 Changes

1 file changed (+104 additions, -30 deletions)

View changed files

📝 Moblin/Media/HaishinKit/Whip/WhipStream.swift (+104 -30)

📄 Description

Changes include:

  • Wait for ICE gathering to complete before sending SDP offer (with fallback timeout)
  • Replace createOffer() with getLocalDescription() for proper ICE candidates
  • Use relative RTP timestamps instead of absolute for H.264
  • Simplify unused delegate parameters and audio RTP packetization

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/eerimoq/moblin/pull/234 **Author:** [@Kn0ax](https://github.com/Kn0ax) **Created:** 2/12/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `whipfixes` --- ### 📝 Commits (1) - [`19d7a82`](https://github.com/eerimoq/moblin/commit/19d7a8232744c084200fcf9f34c1ebe15b88119d) Refactor WhipStream: ICE gathering, cleanup, and RTP improvements ### 📊 Changes **1 file changed** (+104 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `Moblin/Media/HaishinKit/Whip/WhipStream.swift` (+104 -30) </details> ### 📄 Description Changes include: - Wait for ICE gathering to complete before sending SDP offer (with fallback timeout) - Replace createOffer() with getLocalDescription() for proper ICE candidates - Use relative RTP timestamps instead of absolute for H.264 - Simplify unused delegate parameters and audio RTP packetization --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem closed this issue 2026-03-02 04:00:52 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/moblin#235
No description provided.