[PR #217] [MERGED] Fix logger being initialized with old unused setting #219

Closed
opened 2026-03-02 04:00:47 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/eerimoq/moblin/pull/217
Author: @xcopy94
Created: 2/1/2026
Status: Merged
Merged: 2/2/2026
Merged by: @eerimoq

Base: mainHead: dev


📝 Commits (1)

  • 688e5fb Fix logger being initialized with old unused setting

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Moblin/Various/Model/Model.swift (+1 -1)

📄 Description

Since logLevel was replaced by debugLogging in other places and the code doesn't use anything more than info and debug, I wonder if we should keep the SettingsLogLevel enum unused (maybe we find use for .error) or remove logLevel altogether


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/eerimoq/moblin/pull/217 **Author:** [@xcopy94](https://github.com/xcopy94) **Created:** 2/1/2026 **Status:** ✅ Merged **Merged:** 2/2/2026 **Merged by:** [@eerimoq](https://github.com/eerimoq) **Base:** `main` ← **Head:** `dev` --- ### 📝 Commits (1) - [`688e5fb`](https://github.com/eerimoq/moblin/commit/688e5fb7b0ef15cbe3072a0f110def37ef73dc10) Fix logger being initialized with old unused setting ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Moblin/Various/Model/Model.swift` (+1 -1) </details> ### 📄 Description Since logLevel was replaced by debugLogging in other places and the code doesn't use anything more than info and debug, I wonder if we should keep the SettingsLogLevel enum unused (maybe we find use for .error) or remove logLevel altogether --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 04:00:47 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/moblin#219
No description provided.