[PR #103] [CLOSED] Retain active scene on deletion of widget #147

Closed
opened 2026-03-02 04:00:28 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/eerimoq/moblin/pull/103
Author: @lahariganti
Created: 3/4/2025
Status: Closed

Base: mainHead: widdget-delete-scene-change-bug


📝 Commits (3)

  • dbcc22a Retain active scene on deletion of widget
  • e272ec8 Don't change scene on scene manipulation that is not deletion of current scene
  • 6d9e6d1 Revert to expected behavior when moving scenes

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 Moblin/View/Settings/Scenes/ScenesSettingsView.swift (+3 -3)
📝 Moblin/View/Settings/Scenes/Widgets/WidgetsSettingsView.swift (+1 -1)

📄 Description

This PR prevents unexpected scene changes when manipulating scenes/widgets.

https://github.com/user-attachments/assets/5895376e-6999-44d0-80a0-b4a9bac11e1c

https://github.com/user-attachments/assets/884bab06-e32b-4d13-917f-754f99550b07


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/eerimoq/moblin/pull/103 **Author:** [@lahariganti](https://github.com/lahariganti) **Created:** 3/4/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `widdget-delete-scene-change-bug` --- ### 📝 Commits (3) - [`dbcc22a`](https://github.com/eerimoq/moblin/commit/dbcc22a7005f6c3e3f34235eeb1cb460fcd9157f) Retain active scene on deletion of widget - [`e272ec8`](https://github.com/eerimoq/moblin/commit/e272ec8712807081ef9ee465c33efa3c63a024ba) Don't change scene on scene manipulation that is not deletion of current scene - [`6d9e6d1`](https://github.com/eerimoq/moblin/commit/6d9e6d1edf571f4af6b2812c4365325a275821d9) Revert to expected behavior when moving scenes ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Moblin/View/Settings/Scenes/ScenesSettingsView.swift` (+3 -3) 📝 `Moblin/View/Settings/Scenes/Widgets/WidgetsSettingsView.swift` (+1 -1) </details> ### 📄 Description This PR prevents unexpected scene changes when manipulating scenes/widgets. https://github.com/user-attachments/assets/5895376e-6999-44d0-80a0-b4a9bac11e1c https://github.com/user-attachments/assets/884bab06-e32b-4d13-917f-754f99550b07 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 04:00:28 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/moblin#147
No description provided.