[GH-ISSUE #136] mkcert has no tests #84

Open
opened 2026-02-25 22:32:33 +03:00 by kerem · 6 comments
Owner

Originally created by @crawshaw on GitHub (Feb 15, 2019).
Original GitHub issue: https://github.com/FiloSottile/mkcert/issues/136

$ go test ./...
?   	github.com/FiloSottile/mkcert	[no test files]
Originally created by @crawshaw on GitHub (Feb 15, 2019). Original GitHub issue: https://github.com/FiloSottile/mkcert/issues/136 ``` $ go test ./... ? github.com/FiloSottile/mkcert [no test files] ```
Author
Owner

@FiloSottile commented on GitHub (Feb 15, 2019):

Ahem, I might not have initially expected this to become so popular.

Now, tests would have to be integration tests to be meaningful, and that's going to be a pain, in particular on Windows and macOS.

Still, I should do the work. Just whining.

<!-- gh-comment-id:464183174 --> @FiloSottile commented on GitHub (Feb 15, 2019): Ahem, I might not have initially expected this to become so popular. Now, tests would have to be integration tests to be meaningful, and that's going to be a pain, in particular on Windows and macOS. Still, I should do the work. Just whining.
Author
Owner

@adamdecaf commented on GitHub (Feb 15, 2019):

I've done some work around integration tests and certificate stores, it's not fun, but I'd pitch in also. It works okay to spin up docker containers so the host doesn't get trashed on a bad test run.

Old project: https://github.com/adamdecaf/certaudit/tree/master/test

<!-- gh-comment-id:464211732 --> @adamdecaf commented on GitHub (Feb 15, 2019): I've done some work around integration tests and certificate stores, it's not fun, but I'd pitch in also. It works okay to spin up docker containers so the host doesn't get trashed on a bad test run. Old project: https://github.com/adamdecaf/certaudit/tree/master/test
Author
Owner

@rfay commented on GitHub (Aug 20, 2019):

This is super important. It is hard to do tests for all platforms, but as important as this project is, it's really something to be done. Linux is easy of course. macOS is a little harder but CircleCI has macOS instances, unfortunately not free. Appveyor has free (I think) testing for small windows tests like this. Our company runs testbots for windows and macOS via buildkite, so that also might be a path. The sad thing is that the Windows testbots are so terribly unpredictable and have to be restarted too often. This is a pretty simple set of tests though so might work out just fine.

<!-- gh-comment-id:523219999 --> @rfay commented on GitHub (Aug 20, 2019): This is super important. It *is* hard to do tests for all platforms, but as important as this project is, it's really something to be done. Linux is easy of course. macOS is a little harder but CircleCI has macOS instances, unfortunately not free. Appveyor has free (I think) testing for small windows tests like this. Our company runs testbots for windows and macOS via buildkite, so that also might be a path. The sad thing is that the Windows testbots are so terribly unpredictable and have to be restarted too often. This is a pretty simple set of tests though so might work out just fine.
Author
Owner

@adamdecaf commented on GitHub (Aug 20, 2019):

TravisCI has free macOS and windows builders we can use.

<!-- gh-comment-id:523225823 --> @adamdecaf commented on GitHub (Aug 20, 2019): TravisCI has free macOS and windows builders we can use.
Author
Owner

@rfay commented on GitHub (Aug 20, 2019):

Now we just need some people to make the tests :)

<!-- gh-comment-id:523228726 --> @rfay commented on GitHub (Aug 20, 2019): Now we just need some people to make the tests :)
Author
Owner

@FiloSottile commented on GitHub (Aug 21, 2019):

Linux is not trivial, if we want meaningful tests. We need to run in a number of environments, which means we'll probably need some sort of runner/testlet system, and a bunch of Dockerfiles.

I have an idea for the architecture, I was planning to put it together this month.

<!-- gh-comment-id:523242805 --> @FiloSottile commented on GitHub (Aug 21, 2019): Linux is not trivial, if we want meaningful tests. We need to run in a number of environments, which means we'll probably need some sort of runner/testlet system, and a bunch of Dockerfiles. I have an idea for the architecture, I was planning to put it together this month.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/mkcert#84
No description provided.