[PR #593] Prefix message to clarify what is asking for sudo password #504

Open
opened 2026-02-25 22:33:42 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/FiloSottile/mkcert/pull/593
Author: @benmccann
Created: 6/18/2024
Status: 🔄 Open

Base: masterHead: patch-1


📝 Commits (2)

  • cf41ad9 Prefix message to clarify what is asking for sudo password
  • f9dfa46 Update main.go

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 main.go (+1 -1)

📄 Description

I was type checking a javascript file and through a roundabout manner it was invoking mkcert. It was quite scary that such a simple operation was asking for my sudo password without any explanation of where it was coming from or why it was needed. For such a sensitive operation I think it would be helpful to provide more details

This PR uses the text:

mkcert will now install certificates into your root certificate store.
Enter your sudo password:

If we wanted something shorter another alternative might be:

[mkcert] sudo password:

But I thought the longer message provided more explanation of why it's asking for your sudo password.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/FiloSottile/mkcert/pull/593 **Author:** [@benmccann](https://github.com/benmccann) **Created:** 6/18/2024 **Status:** 🔄 Open **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`cf41ad9`](https://github.com/FiloSottile/mkcert/commit/cf41ad9bb2d386adb521a3efeee1f4dcd37af501) Prefix message to clarify what is asking for sudo password - [`f9dfa46`](https://github.com/FiloSottile/mkcert/commit/f9dfa4623d6469c0f02315641317c4c549e66227) Update main.go ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `main.go` (+1 -1) </details> ### 📄 Description I was type checking a javascript file and through a roundabout manner it was invoking mkcert. It was quite scary that such a simple operation was asking for my sudo password without any explanation of where it was coming from or why it was needed. For such a sensitive operation I think it would be helpful to provide more details This PR uses the text: >mkcert will now install certificates into your root certificate store. Enter your sudo password: If we wanted something shorter another alternative might be: >[mkcert] sudo password: But I thought the longer message provided more explanation of _why_ it's asking for your sudo password. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/mkcert#504
No description provided.